github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #3559 from overleaf/ta-file-tree-404-fix

Browse source 
[ReactFileTree] Fix Handling of 404 on Deletion

GitOrigin-RevId: 8b955710929246168ac5cc29acda7a893164fc1d
This commit is contained in:
Eric Mc Sween 2021-01-14 08:58:02 -05:00 committed by Copybot
parent dc48ba1d61
commit 5f9544ad69
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/frontend/js/features/file-tree/contexts/file-tree-actionable.js
View file

@ -179,7 +179,7 @@ export function useFileTreeActionable() {
return syncDelete(projectId, found.type, found.entity._id).catch(
error => {
// throw unless 404
if (error.info.statusCode !== '404') {
if (error.info.statusCode !== 404) {
throw error
}
}

13
services/web/test/frontend/features/file-tree/flows/delete-entity.test.js
View file

@ -74,6 +74,9 @@ describe('FileTree Delete Entity Flow', function() {
name: 'main.tex'
})
).to.not.exist
// check that the confirmation modal is closed
expect(screen.queryByText(/Are you sure/)).to.not.exist
})
const [lastFetchPath] = fetchMock.lastCall(fetchMatcher)
@ -88,6 +91,9 @@ describe('FileTree Delete Entity Flow', function() {
window._ide.socket.socketClient.emit('removeEntity', '456def')
// check that the confirmation modal is open
screen.getByText(/Are you sure/)
await waitFor(() => {
expect(
screen.queryByRole('treeitem', {
@ -101,6 +107,10 @@ describe('FileTree Delete Entity Flow', function() {
name: 'main.tex'
})
).to.not.exist
// check that the confirmation modal is closed
// is not, the 404 probably triggered a bug
expect(screen.queryByText(/Are you sure/)).to.not.exist
})
})
@ -228,6 +238,9 @@ describe('FileTree Delete Entity Flow', function() {
name
})
).to.not.exist
// check that the confirmation modal is closed
expect(screen.queryByText(/Are you sure/)).to.not.exist
}
})