github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-12-24 03:23:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2626 from overleaf/bg-fix-editor-regexps

Browse source 
fix stateful regexp usage in editor inputs

GitOrigin-RevId: 4950066251cb6235e218ff4f600fab2652d15e76
This commit is contained in:
Eric Mc Sween 2020-02-27 07:47:41 -05:00 committed by Copybot
parent c120309dd0
commit 5f712645ed
1 changed files with 16 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
services/web/frontend/js/ide/editor/directives/aceEditor.js
View file

@ -201,28 +201,24 @@ define([
// you can modify the input or reject the event with e.preventDefault()
editor.commands.on('exec', function(e) {
// replace bad characters in paste content
if (
e.command &&
e.command.name === 'paste' &&
e.args &&
BAD_CHARS_REGEXP.test(e.args.text)
) {
e.args.text = e.args.text.replace(
BAD_CHARS_REGEXP,
BAD_CHARS_REPLACEMENT_CHAR
)
if (e.command && e.command.name === 'paste') {
BAD_CHARS_REGEXP.lastIndex = 0 // reset stateful regexp for this usage
if (e.args && BAD_CHARS_REGEXP.test(e.args.text)) {
e.args.text = e.args.text.replace(
BAD_CHARS_REGEXP,
BAD_CHARS_REPLACEMENT_CHAR
)
}
}
// replace bad characters in keyboard input
if (
e.command &&
e.command.name === 'insertstring' &&
e.args &&
BAD_CHARS_REGEXP.test(e.args)
) {
e.args = e.args.replace(
BAD_CHARS_REGEXP,
BAD_CHARS_REPLACEMENT_CHAR
)
if (e.command && e.command.name === 'insertstring') {
BAD_CHARS_REGEXP.lastIndex = 0 // reset stateful regexp for this usage
if (e.args && BAD_CHARS_REGEXP.test(e.args)) {
e.args = e.args.replace(
BAD_CHARS_REGEXP,
BAD_CHARS_REPLACEMENT_CHAR
)
}
}
})