From 5821dc727354b8557f03f2c47daa1b5219e78d59 Mon Sep 17 00:00:00 2001 From: Antoine Clausse Date: Fri, 8 Nov 2024 11:40:23 +0100 Subject: [PATCH] [web] Fix main branch linting error (#21749) * Sync package-lock I get this change when running `make install && bin/npm i` * Add `featureUsage` to LoggedOutUser keys We might want to change this to something like this: ``` export type NullifyProperties = { [P in keyof T]: undefined } export type LoggedOutUser = { id: null } & NullifyProperties> ``` * Revert "Sync package-lock" This reverts commit 982466eba3f8d72a388d248b66658be0350b2d09. * Remove `canceledSubscription` types for now This is breaking the build at the moment. We can work on creating a `Request` that matches our usages of it GitOrigin-RevId: bb21baba6a074c2169af786a9e56b33beddddd2f --- .../app/src/Features/Subscription/SubscriptionController.js | 3 --- services/web/types/user.ts | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/services/web/app/src/Features/Subscription/SubscriptionController.js b/services/web/app/src/Features/Subscription/SubscriptionController.js index 149c3ac993..5e04711b38 100644 --- a/services/web/app/src/Features/Subscription/SubscriptionController.js +++ b/services/web/app/src/Features/Subscription/SubscriptionController.js @@ -457,9 +457,6 @@ function cancelSubscription(req, res, next) { } /** - * @param {import('express').Request} req - * @param {import('express').Response} res - * @param {import('express').NextFunction} next * @returns {Promise} */ async function canceledSubscription(req, res, next) { diff --git a/services/web/types/user.ts b/services/web/types/user.ts index 5cb6459a83..dd176bdd0e 100644 --- a/services/web/types/user.ts +++ b/services/web/types/user.ts @@ -68,6 +68,7 @@ export type LoggedOutUser = { refProviders?: undefined writefull?: undefined isAdmin?: undefined + featureUsage?: undefined } export type MongoUser = Pick> & { _id: string }