From 567edbfb31544d4c5ff3fdb1144ec403af0599d3 Mon Sep 17 00:00:00 2001 From: James Allen Date: Mon, 3 Apr 2017 17:11:33 +0100 Subject: [PATCH] Fix on the new comment button variation --- .../web/app/views/project/editor/review-panel.pug | 2 +- .../controllers/ReviewPanelController.coffee | 14 ++------------ 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/services/web/app/views/project/editor/review-panel.pug b/services/web/app/views/project/editor/review-panel.pug index da14b69a99..ca9edbf14f 100644 --- a/services/web/app/views/project/editor/review-panel.pug +++ b/services/web/app/views/project/editor/review-panel.pug @@ -8,7 +8,7 @@ ) !{translate("track_changes_is_on")} a.rp-add-comment-btn( href - ng-if="reviewPanel.newAddCommentUI && reviewPanel.entries[editor.open_doc_id]['add-comment'] != null" + ng-if="reviewPanel.entries[editor.open_doc_id]['add-comment'] != null" ng-click="addNewComment();" ) i.fa.fa-comment diff --git a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee index fff1d31671..d80c903b57 100644 --- a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee +++ b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee @@ -4,7 +4,7 @@ define [ "ide/colors/ColorManager" "ide/review-panel/RangesTracker" ], (App, EventEmitter, ColorManager, RangesTracker) -> - App.controller "ReviewPanelController", ($scope, $element, ide, $timeout, $http, $modal, event_tracking, sixpack, localStorage) -> + App.controller "ReviewPanelController", ($scope, $element, ide, $timeout, $http, $modal, event_tracking, localStorage) -> $reviewPanelEl = $element.find "#review-panel" $scope.SubViews = @@ -27,14 +27,6 @@ define [ layoutToLeft: false rendererData: {} loadingThreads: false - newAddCommentUI: false # Test new UI for adding comments; remove afterwards. - - $scope.shouldABAddCommentBtn = false - if $scope.user.signUpDate >= '2017-03-27' - sixpack.participate "add-comment-btn", [ "default", "editor-corner" ], (variation) -> - $scope.shouldABAddCommentBtn = true - $scope.variationABAddCommentBtn = variation - $scope.reviewPanel.newAddCommentUI = (variation == "editor-corner") window.addEventListener "beforeunload", () -> collapsedStates = {} @@ -173,7 +165,7 @@ define [ entries = $scope.reviewPanel.entries[$scope.editor.open_doc_id] or {} permEntries = {} for entry, entryData of entries - if entry != "add-comment" or !$scope.reviewPanel.newAddCommentUI + if entry != "add-comment" permEntries[entry] = entryData Object.keys(permEntries).length ), (nEntries) -> @@ -336,8 +328,6 @@ define [ $scope.$broadcast "comment:select_line" $timeout () -> $scope.$broadcast "review-panel:layout" - if $scope.shouldABAddCommentBtn and !$scope.ui.reviewPanelOpen - sixpack.convert "add-comment-btn" $scope.submitNewComment = (content) -> return if !content? or content == ""