github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-20 13:33:42 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2311 from overleaf/fix-err-error-checks

Browse source 
Fix two err/error confusion issues

GitOrigin-RevId: 3dfdeffa5a8d13d64dca3f70533a87c70a06d49b
This commit is contained in:
Timothée Alby 2019-11-04 16:49:58 +07:00 • committed by sharelatex
parent df45df5b71
commit 56566106c2
2 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
services/web/app/src/Features/Chat/ChatController.js
View file

@ -113,13 +113,11 @@ module.exports = ChatController = {
const _ = user_ids[user_id]
;(user_id =>
jobs.push(cb =>
UserInfoManager.getPersonalInfo(user_id, function(err, user) {
if (typeof error !== 'undefined' && error !== null) {
return cb(error)
}
UserInfoManager.getPersonalInfo(user_id, function(error, user) {
if (error != null) return cb(error)
user = UserInfoController.formatPersonalInfo(user)
users[user_id] = user
return cb()
cb()
})
))(user_id)
}

8
services/web/app/src/Features/History/HistoryController.js
View file

@ -184,11 +184,9 @@ module.exports = HistoryController = {
project_id,
doc_id,
name,
(err, doc) => {
if (typeof error !== 'undefined' && error !== null) {
return next(error)
}
return res.json({
(error, doc) => {
if (error != null) return next(error)
res.json({
doc_id: doc._id
})
}