github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-01-27 00:54:27 +00:00
Code Issues Projects Releases Packages Wiki Activity

[DockerRunner] destroyOldContainers: normalize the container name

Browse source 
The docker api returns each name with a `/` prefix.

In order to not interfere with pending compiles, the deletion process
 has to acquire an internal lock on the container. The LockManager uses
 the plain container name without the slash: `project-xxx`.

Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
This commit is contained in:
Jakob Ackermann 2019-11-27 21:40:48 +01:00 committed by Jakob Ackermann
parent 7b9912034d
commit 563a973388
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/clsi/app/js/DockerRunner.js
View file

@ -632,6 +632,9 @@ module.exports = DockerRunner = {
ttl
) {
if (name.slice(0, 9) === '/project-' && ttl <= 0) {
// strip the / prefix
// the LockManager uses the plain container name
name = name.slice(1)
return jobs.push(cb =>
DockerRunner.destroyContainer(name, id, false, () => cb())
)

6
services/clsi/test/unit/js/DockerRunnerTests.js
View file

@ -630,19 +630,19 @@ describe('DockerRunner', function() {
it('should destroy old containers', function() {
this.DockerRunner.destroyContainer.callCount.should.equal(1)
return this.DockerRunner.destroyContainer
.calledWith('/project-old-container-name', 'old-container-id')
.calledWith('project-old-container-name', 'old-container-id')
.should.equal(true)
})
it('should not destroy new containers', function() {
return this.DockerRunner.destroyContainer
.calledWith('/project-new-container-name', 'new-container-id')
.calledWith('project-new-container-name', 'new-container-id')
.should.equal(false)
})
it('should not destroy non-project containers', function() {
return this.DockerRunner.destroyContainer
.calledWith('/totally-not-a-project-container', 'some-random-id')
.calledWith('totally-not-a-project-container', 'some-random-id')
.should.equal(false)
})