Tear Down - Tearing down of registration and login pages redesign tests (#19750)

* tearing down the test for registration page

* deleting files that were used in delete register.pug file

* removing usage of websiteRedesignAssignmentVariant from remaining files

* deleting files for login page except ligh version

* removing the usage of websiteRedesignAssignmentVariant in remaining files

* moving light design to views folder because app was breaking, also renaming the file to login.pug and moving the two related files to views folder

* running make cleanup_unused_locales

* updating the acceptance test to reflect the change

* tested the deleted register files and rmeoved the classes that were only being used in the deleted register files

* adding delete comments on classes for these files _registration_user_password _registration_sso

* combining the two .login-register-form-focus into one within website-redesign

* fixing the positioning of the validation message

* moving register files out of website-redesign

* adding back AnalyticsManager for view events

GitOrigin-RevId: 028bd65824c4d09cc6ad9950159a404af55ff97e
This commit is contained in:
Davinder Singh 2024-08-20 13:34:56 +01:00 committed by Copybot
parent 777acc4040
commit 54f0c24633
3 changed files with 5 additions and 81 deletions

View file

@ -37,9 +37,6 @@
border-bottom-width: 0;
}
}
.login-register-other-links {
padding: @line-height-computed;
}
.login-register-text,
.login-register-hr-text-container {
@ -89,21 +86,9 @@
}
}
.login-btn-icon-ieee {
background-image: url(../../../public/img/other-brands/logo_ieee.svg);
}
.login-btn-icon-google {
background-image: url(../../../public/img/other-brands/logo_google.svg);
}
.login-btn-icon-twitter {
background-image: url(../../../public/img/other-brands/logo_twitter.svg);
}
.login-btn-icon-orcid {
background-image: url(../../../public/img/other-brands/logo_orcid.svg);
}
.login-btn-icon-institution {
background-image: url(../../../public/img/other-brands/logo_institution.svg);
}
.registration-message-heading {
color: @text-color;
@ -122,22 +107,6 @@
max-width: 320px;
}
.login-overleaf-logo-container {
padding: 15px;
width: 65px;
display: flex;
justify-content: center;
align-items: center;
.login-overleaf-logo {
width: 35px;
}
@media (max-width: @screen-xs-max) {
margin-top: @margin-lg;
}
}
.login-register-text {
font-size: 0.875rem;
line-height: 1.4;
@ -220,6 +189,7 @@
.form-group-password {
display: flex;
position: relative;
flex-direction: column;
.form-group-password-input {
input.form-control {
@ -262,12 +232,6 @@
min-height: 100vh;
}
// TODO: One of these two classes should be removed when test is tearing down.
.register-content-container-light {
.register-content-container;
background-color: @white;
}
.register-form {
width: 100%;
height: 100%;
@ -357,32 +321,6 @@
}
}
// TODO: This is Temporary class for split test to center align the text, we can remove this during the tear down of the test based on the winner variant.
.light-variant {
.tos-agreement-notice {
text-align: center;
font-size: 12px;
a {
color: var(--green-50);
text-decoration: underline;
// text-decoration-;skip-ink is for letter with descender (like 'g' and 'y')
// this will force underline to not skip the descender
text-decoration-skip-ink: none;
&:hover {
color: var(--green-60);
}
// for accessibility with keyboard navigation
&:focus {
outline: 2px solid var(--green-50);
outline-offset: 1px;
}
}
}
}
.register-header-logo {
&:focus {
outline: 2px solid var(--green-50);

View file

@ -8,10 +8,6 @@
padding: 8px 0;
}
.login-register-header-focus {
padding-top: @line-height-computed;
}
.website-redesign {
.login-register-header-focus {
padding-top: unset;
@ -23,18 +19,13 @@
margin-bottom: 0;
}
.login-register-form-focus {
padding: @line-height-computed;
padding-bottom: 0;
border-bottom: solid 1px @hr-border;
&:last-child {
border-bottom-width: 0;
}
}
.website-redesign {
.login-register-form-focus {
padding: @line-height-computed 0 0 0;
border-bottom: unset;
border-bottom: solid 1px @hr-border;
&:last-child {
border-bottom-width: 0;
}
}
}

View file

@ -687,7 +687,6 @@
"for_teams_and_organizations_who_want_a_streamlined_sso_and_security": "For teams and organizations who want a streamlined sign-on process and our strongest cloud security.",
"for_universities": "For universities",
"forever": "forever",
"forgot_password": "Forgot password?",
"forgot_your_password": "Forgot your password",
"format": "Format",
"found_matching_deleted_users": "Found __deletedUserCount__ matching deleted users",
@ -1120,7 +1119,6 @@
"log_in_with": "Log in with __provider__",
"log_in_with_a_different_account": "Log in with a different account",
"log_in_with_email": "Log in with __email__",
"log_in_with_email_raw": "Log in with email",
"log_in_with_existing_institution_email": "Please log in with your existing <b>__appName__</b> account in order to get your <b>__appName__</b> and <b>__institutionName__</b> institutional accounts linked.",
"log_in_with_primary_email_address": "This will be the email address to use if you log in with an email address and password. Important __appName__ notifications will be sent to this email address.",
"log_in_with_sso": "Log in with SSO",
@ -1604,12 +1602,9 @@
"regards": "Regards",
"register": "Register",
"register_error": "Registration error",
"register_for_overleaf": "Register for __appName__",
"register_intercept_sso": "You can link your __authProviderName__ account from the Account Settings page after logging in.",
"register_to_accept_invitation": "Register to accept invitation",
"register_to_edit_template": "Please register to edit the __templateName__ template",
"register_using_email": "Register using your email",
"register_using_service": "Register using __service__",
"register_with_another_email": "<a href=\"__link__\">Register with __appName__</a> using another email.",
"registered": "Registered",
"registering": "Registering",