github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #188 from overleaf/jpa-drop-duplicate-log

Browse source 
[misc] drop duplicate logs
This commit is contained in:
Jakob Ackermann 2020-09-02 10:45:57 +02:00 committed by GitHub
commit 54c0853aa5
3 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
services/real-time/app/js/WebApiManager.js
View file

@ -49,7 +49,6 @@ module.exports = {
data.isRestrictedUser data.isRestrictedUser
) )
} else if (response.statusCode === 429) { } else if (response.statusCode === 429) {
logger.log(project_id, user_id, 'rate-limit hit when joining project')
callback( callback(
new CodedError( new CodedError(
'rate-limit hit when joining project', 'rate-limit hit when joining project',

4
services/real-time/app/js/WebsocketController.js
View file

@ -462,10 +462,6 @@ module.exports = WebsocketController = {
update, update,
function (error) { function (error) {
if (error) { if (error) {
logger.warn(
{ err: error, doc_id, client_id: client.id, version: update.v },
'client is not authorized to make update'
)
setTimeout( setTimeout(
() => () =>
// Disconnect, but give the client the chance to receive the error // Disconnect, but give the client the chance to receive the error

4
services/real-time/test/unit/js/WebsocketControllerTests.js
View file

@ -1493,8 +1493,8 @@ describe('WebsocketController', function () {
// it "should disconnect the client", -> // it "should disconnect the client", ->
// @client.disconnect.called.should.equal true // @client.disconnect.called.should.equal true
it('should log a warning', function () { it('should not log a warning', function () {
return this.logger.warn.called.should.equal(true) return this.logger.warn.called.should.equal(false)
}) })
return it('should call the callback with the error', function () { return it('should call the callback with the error', function () {