From 522786d45e1c1783fff52218894fa8bb990c634a Mon Sep 17 00:00:00 2001 From: Shane Kilkelly Date: Wed, 9 Sep 2015 15:48:22 +0100 Subject: [PATCH] Produce a null value, rather than crashing when the user info service returns 404. --- services/track-changes/app/coffee/WebApiManager.coffee | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/services/track-changes/app/coffee/WebApiManager.coffee b/services/track-changes/app/coffee/WebApiManager.coffee index 555dc0179c..9264862fa3 100644 --- a/services/track-changes/app/coffee/WebApiManager.coffee +++ b/services/track-changes/app/coffee/WebApiManager.coffee @@ -13,6 +13,8 @@ module.exports = WebApiManager = }, (error, res, body)-> if error? return callback(error) + if res.statusCode == 404 + return callback null, null if res.statusCode >= 200 and res.statusCode < 300 return callback null, body else @@ -27,6 +29,9 @@ module.exports = WebApiManager = logger.error err: error, user_id: user_id, url: url, "error accessing web" return callback error + if body == null + logger.error user_id: user_id, url: url, "no user found" + return callback null, null try user = JSON.parse(body) catch error