github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-03-03 20:22:59 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #109 from overleaf/spd-end-stream-on-premature-close

Browse source 
Call end() when handing ERR_STREAM_PREMATURE_CLOSE
This commit is contained in:
Simon Detheridge 2020-03-31 11:33:17 +01:00 committed by GitHub
commit 51a6dda660
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/filestore/app/js/FileController.js
View file

@ -61,7 +61,12 @@ function getFile(req, res, next) {
}
pipeline(fileStream, res, err => {
if (err && err.code !== 'ERR_STREAM_PREMATURE_CLOSE') {
if (!fileStream.destroyed) {
fileStream.destroy()
}
if (err && err.code === 'ERR_STREAM_PREMATURE_CLOSE') {
res.end()
} else if (err) {
next(
new Errors.ReadError({
message: 'error transferring stream',

7
services/filestore/app/js/PersistorHelper.js
View file

@ -112,6 +112,13 @@ function getReadyPipeline(...streams) {
}
resolve(lastStream)
}
if (err) {
for (const stream of streams) {
if (!stream.destroyed) {
stream.destroy()
}
}
}
}
pipeline(...streams).catch(handler)