github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-12-28 00:11:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

Check the subscription is in a group plan before adding new members

Browse source
This commit is contained in:
Alberto Fernández Capel 2018-06-08 09:58:51 +01:00
parent c4250e601e
commit 5159f6f33d
2 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/app/coffee/Features/Subscription/TeamInvitesHandler.coffee
View file

@ -124,6 +124,11 @@ removeInviteFromTeam = (subscriptionId, email, callback) ->
checkIfInviteIsPossible = (subscription, email, callback = (error, possible, reason) -> ) ->
unless subscription.groupPlan
logger.log {subscriptionId: subscription.id},
"can not add members to a subscription that is not in a group plan"
return callback(null, false, wrongPlan: true)
if LimitationsManager.teamHasReachedMemberLimit(subscription)
logger.log {subscriptionId: subscription.id}, "team has reached member limit"
return callback(null, false, limitReached: true)

13
services/web/test/unit/coffee/Subscription/TeamInvitesHandlerTests.coffee
View file

@ -26,9 +26,10 @@ describe "TeamInvitesHandler", ->
@subscription = {
id: "55153a8014829a865bbf700d",
admin_id: @manager.id,
member_ids: []
teamInvites: [ @teamInvite ]
save: sinon.stub().yields(null)
groupPlan: true,
member_ids: [],
teamInvites: [ @teamInvite ],
save: sinon.stub().yields(null),
}
@SubscriptionLocator = {
@ -234,6 +235,12 @@ describe "TeamInvitesHandler", ->
expect(err).to.deep.equal(limitReached: true)
done()
it "doesn't create an invite if the subscription is not in a group plan", (done) ->
@subscription.groupPlan = false
@TeamInvitesHandler.createInvite @manager.id, "John.Snow@nightwatch.com", (err, invite) =>
expect(err).to.deep.equal(wrongPlan: true)
done()
it "doesn't create an invite if the user is already part of the team", (done) ->
member = {
id: "1a2b",