github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-01-26 18:21:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #19712 from overleaf/ae-fetch-first-log-part

Browse source 
Stream and truncate large log files

GitOrigin-RevId: 9d9058d1cc0b3c7a56b25ff34f7a41bfe3e59772
This commit is contained in:
Alf Eaton 2024-08-07 08:57:11 +01:00 committed by Copybot
parent f7d1dac005
commit 5067c0b22d
1 changed files with 25 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
services/web/frontend/js/features/pdf-preview/util/output-files.js
View file

@ -7,6 +7,8 @@ import { dirname, findEntityByPath } from '@/features/file-tree/util/path'
// Warnings that may disappear after a second LaTeX pass
const TRANSIENT_WARNING_REGEX = /^(Reference|Citation).+undefined on input line/
const MAX_LOG_SIZE = 1024 * 1024 // 1MB
export function handleOutputFiles(outputFiles, projectId, data) {
const outputFile = outputFiles.get('output.pdf')
if (!outputFile) return null
@ -75,12 +77,31 @@ export const handleLogFiles = async (outputFiles, data, signal) => {
if (logFile) {
try {
const response = await fetch(buildURL(logFile, data.pdfDownloadDomain), {
signal,
const logFileAbortController = new AbortController()
// abort fetching the log file if the main signal is aborted
signal.addEventListener('abort', () => {
logFileAbortController.abort()
})
result.log = await response.text()
const response = await fetch(buildURL(logFile, data.pdfDownloadDomain), {
signal: logFileAbortController.signal,
})
result.log = ''
const reader = response.body.pipeThrough(new TextDecoderStream())
for await (const chunk of reader) {
result.log += chunk
if (result.log.length > MAX_LOG_SIZE) {
logFileAbortController.abort()
}
}
} catch (e) {
debugConsole.warn(e) // ignore failure to fetch the log file, but log a warning
}
try {
let { errors, warnings, typesetting } = HumanReadableLogs.parse(
result.log,
{
@ -95,7 +116,7 @@ export const handleLogFiles = async (outputFiles, data, signal) => {
accumulateResults({ errors, warnings, typesetting })
} catch (e) {
debugConsole.warn(e) // ignore failure to fetch/parse the log file, but log a warning
debugConsole.warn(e) // ignore failure to parse the log file, but log a warning
}
}