From 4f127f840815e6f292b343a89bf7cc4e66060204 Mon Sep 17 00:00:00 2001 From: M Fahru Date: Fri, 3 Jun 2022 04:06:17 -0400 Subject: [PATCH] Add new "Premium Features" link on the navbar "Features & Benefits", and hide it behind the "premium-features-discoverability" split test (#8269) GitOrigin-RevId: 5dae86818a485c74078683422ec44008fd754f27 --- services/web/app/src/router.js | 5 ++++- services/web/app/views/layout/navbar-marketing.pug | 13 +++++++++++++ services/web/app/views/layout/navbar.pug | 13 +++++++++++++ 3 files changed, 30 insertions(+), 1 deletion(-) diff --git a/services/web/app/src/router.js b/services/web/app/src/router.js index 349e57957b..66125d3357 100644 --- a/services/web/app/src/router.js +++ b/services/web/app/src/router.js @@ -78,7 +78,10 @@ function initialize(webRouter, privateApiRouter, publicApiRouter) { webRouter.get( '*', expressify( - SplitTestMiddleware.loadAssignmentsInLocals(['unified-navigation']) + SplitTestMiddleware.loadAssignmentsInLocals([ + 'unified-navigation', + 'premium-features-discoverability', + ]) ) ) diff --git a/services/web/app/views/layout/navbar-marketing.pug b/services/web/app/views/layout/navbar-marketing.pug index 68cabda1fb..ee632951b7 100644 --- a/services/web/app/views/layout/navbar-marketing.pug +++ b/services/web/app/views/layout/navbar-marketing.pug @@ -75,6 +75,19 @@ nav.navbar.navbar-default.navbar-main each child in item.dropdown if child.divider li.divider + if child.splitTest + if (splitTestVariants && (splitTestVariants[child.splitTest.name] === child.splitTest.variant)) + li + if child.url + a( + href=child.url, + class=child.class, + event-tracking=child.event + event-tracking-mb="true" + event-tracking-trigger="click" + ) !{translate(child.text)} + else + | !{translate(child.text)} else li if child.url diff --git a/services/web/app/views/layout/navbar.pug b/services/web/app/views/layout/navbar.pug index bb23ca4571..fbf19b63ca 100644 --- a/services/web/app/views/layout/navbar.pug +++ b/services/web/app/views/layout/navbar.pug @@ -58,6 +58,19 @@ nav.navbar.navbar-default.navbar-main each child in item.dropdown if child.divider li.divider + if child.splitTest + if (splitTestVariants && (splitTestVariants[child.splitTest.name] === child.splitTest.variant)) + li + if child.url + a( + href=child.url, + class=child.class, + event-tracking=child.event + event-tracking-mb="true" + event-tracking-trigger="click" + ) !{translate(child.text)} + else + | !{translate(child.text)} else li if child.url