From 4e7fbcfe2eba0237587cb9aa646377952a5b45b3 Mon Sep 17 00:00:00 2001
From: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
Date: Tue, 28 May 2024 11:48:42 +0300
Subject: [PATCH] Merge pull request #18473 from
 overleaf/ii-bs5-settings-grid-fix

[web] Adjust column breakpoints in bs5 account settings page

GitOrigin-RevId: 90e7fe7561a75439166472627fdb6189ebcdefa1
---
 .../settings/components/emails/add-email.tsx  | 16 +++----
 .../settings/components/emails/header.tsx     |  4 +-
 .../components/emails/reconfirmation-info.tsx |  4 +-
 .../settings/components/emails/row.tsx        | 18 ++++----
 .../js/features/settings/components/root.tsx  |  6 +--
 .../js/features/ui/components/ol/ol-col.tsx   | 44 +++++++++++++++----
 6 files changed, 60 insertions(+), 32 deletions(-)

diff --git a/services/web/frontend/js/features/settings/components/emails/add-email.tsx b/services/web/frontend/js/features/settings/components/emails/add-email.tsx
index 08c4eb5295..0803e0c9ba 100644
--- a/services/web/frontend/js/features/settings/components/emails/add-email.tsx
+++ b/services/web/frontend/js/features/settings/components/emails/add-email.tsx
@@ -109,7 +109,7 @@ function AddEmail() {
   if (!isFormVisible) {
     return (
       <Layout isError={isError} error={error}>
-        <OLCol md={12}>
+        <OLCol lg={12}>
           <Cell>
             {state.data.emailCount >= emailAddressLimit ? (
               <span className="small">
@@ -152,7 +152,7 @@ function AddEmail() {
       <form>
         <Layout isError={isError} error={error}>
           <ReCaptcha2 page="addEmail" ref={recaptchaRef} />
-          <OLCol md={8}>
+          <OLCol lg={8}>
             <Cell>
               {InputComponent}
               <div className="affiliations-table-cell-tabbed">
@@ -160,10 +160,10 @@ function AddEmail() {
               </div>
             </Cell>
           </OLCol>
-          <OLCol md={4}>
+          <OLCol lg={4}>
             <Cell
               className={bsVersion({
-                bs5: 'text-md-end',
+                bs5: 'text-lg-end',
                 bs3: 'text-md-right',
               })}
             >
@@ -182,7 +182,7 @@ function AddEmail() {
     <form>
       <Layout isError={isError} error={error}>
         <ReCaptcha2 page="addEmail" ref={recaptchaRef} />
-        <OLCol md={8}>
+        <OLCol lg={8}>
           <Cell>
             {InputComponent}
             {!isSsoAvailableForDomain ? (
@@ -205,10 +205,10 @@ function AddEmail() {
           </Cell>
         </OLCol>
         {!isSsoAvailableForDomain ? (
-          <OLCol md={4}>
+          <OLCol lg={4}>
             <Cell
               className={bsVersion({
-                bs5: 'text-md-end',
+                bs5: 'text-lg-end',
                 bs3: 'text-md-right',
               })}
             >
@@ -221,7 +221,7 @@ function AddEmail() {
             </Cell>
           </OLCol>
         ) : (
-          <OLCol md={12}>
+          <OLCol lg={12}>
             <Cell>
               <div className="affiliations-table-cell-tabbed">
                 <SsoLinkingInfo
diff --git a/services/web/frontend/js/features/settings/components/emails/header.tsx b/services/web/frontend/js/features/settings/components/emails/header.tsx
index 3948580e46..c7cb6283d7 100644
--- a/services/web/frontend/js/features/settings/components/emails/header.tsx
+++ b/services/web/frontend/js/features/settings/components/emails/header.tsx
@@ -12,7 +12,7 @@ function Header() {
     <>
       <OLRow>
         <OLCol
-          md={4}
+          lg={4}
           className={bsVersion({
             bs5: 'd-none d-sm-block',
             bs3: 'hidden-xs',
@@ -23,7 +23,7 @@ function Header() {
           </EmailCell>
         </OLCol>
         <OLCol
-          md={8}
+          lg={8}
           className={bsVersion({
             bs5: 'd-none d-sm-block',
             bs3: 'hidden-xs',
diff --git a/services/web/frontend/js/features/settings/components/emails/reconfirmation-info.tsx b/services/web/frontend/js/features/settings/components/emails/reconfirmation-info.tsx
index 89aeeedaa6..b99c8f14a7 100644
--- a/services/web/frontend/js/features/settings/components/emails/reconfirmation-info.tsx
+++ b/services/web/frontend/js/features/settings/components/emails/reconfirmation-info.tsx
@@ -81,7 +81,7 @@ function ReconfirmationInfo({ userEmailData }: ReconfirmationInfoProps) {
   ) {
     return (
       <OLRow>
-        <OLCol md={12}>
+        <OLCol lg={12}>
           <OLNotification
             type="info"
             content={
@@ -99,7 +99,7 @@ function ReconfirmationInfo({ userEmailData }: ReconfirmationInfoProps) {
   if (userEmailData.affiliation.inReconfirmNotificationPeriod) {
     return (
       <OLRow>
-        <OLCol md={12}>
+        <OLCol lg={12}>
           {isBootstrap5 ? (
             <OLNotification
               type="info"
diff --git a/services/web/frontend/js/features/settings/components/emails/row.tsx b/services/web/frontend/js/features/settings/components/emails/row.tsx
index 7072d93938..8254bb8d62 100644
--- a/services/web/frontend/js/features/settings/components/emails/row.tsx
+++ b/services/web/frontend/js/features/settings/components/emails/row.tsx
@@ -30,22 +30,22 @@ function EmailsRow({ userEmailData }: EmailsRowProps) {
   return (
     <>
       <OLRow>
-        <OLCol md={4}>
+        <OLCol lg={4}>
           <EmailCell>
             <Email userEmailData={userEmailData} />
           </EmailCell>
         </OLCol>
-        <OLCol md={5}>
+        <OLCol lg={5}>
           {userEmailData.affiliation?.institution && (
             <EmailCell>
               <InstitutionAndRole userEmailData={userEmailData} />
             </EmailCell>
           )}
         </OLCol>
-        <OLCol md={3}>
+        <OLCol lg={3}>
           <EmailCell
             className={bsVersion({
-              bs5: 'text-md-end',
+              bs5: 'text-lg-end',
               bs3: 'text-md-right',
             })}
           >
@@ -94,7 +94,7 @@ function SSOAffiliationInfo({ userEmailData }: SSOAffiliationInfoProps) {
   if (userEmailData.samlProviderId) {
     return (
       <OLRow>
-        <OLCol md={{ span: 8, offset: 4 }}>
+        <OLCol lg={{ span: 8, offset: 4 }}>
           <EmailCell>
             <p>
               <Trans
@@ -118,10 +118,10 @@ function SSOAffiliationInfo({ userEmailData }: SSOAffiliationInfoProps) {
 
   return (
     <OLRow>
-      <OLCol md={{ span: 8, offset: 4 }}>
+      <OLCol lg={{ span: 8, offset: 4 }}>
         <div className="horizontal-divider" />
         <OLRow>
-          <OLCol md={9}>
+          <OLCol lg={9}>
             <EmailCell>
               <p className="small">
                 <Trans
@@ -153,9 +153,9 @@ function SSOAffiliationInfo({ userEmailData }: SSOAffiliationInfoProps) {
             </EmailCell>
           </OLCol>
           <OLCol
-            md={3}
+            lg={3}
             className={bsVersion({
-              bs5: 'text-md-end',
+              bs5: 'text-lg-end',
               bs3: 'text-md-right',
             })}
           >
diff --git a/services/web/frontend/js/features/settings/components/root.tsx b/services/web/frontend/js/features/settings/components/root.tsx
index 170044dcb2..2c0d43e968 100644
--- a/services/web/frontend/js/features/settings/components/root.tsx
+++ b/services/web/frontend/js/features/settings/components/root.tsx
@@ -35,7 +35,7 @@ function SettingsPageRoot() {
   return (
     <div className="container">
       <OLRow>
-        <OLCol md={12} lg={{ span: 10, offset: 1 }}>
+        <OLCol xl={{ span: 10, offset: 1 }}>
           {isReady ? <SettingsPageContent /> : null}
         </OLCol>
       </OLRow>
@@ -60,10 +60,10 @@ function SettingsPageContent() {
           <EmailsSection />
           <SSOAlert />
           <OLRow>
-            <OLCol md={5}>
+            <OLCol lg={5}>
               <AccountInfoSection />
             </OLCol>
-            <OLCol md={{ span: 5, offset: 1 }}>
+            <OLCol lg={{ span: 5, offset: 1 }}>
               <PasswordSection />
             </OLCol>
           </OLRow>
diff --git a/services/web/frontend/js/features/ui/components/ol/ol-col.tsx b/services/web/frontend/js/features/ui/components/ol/ol-col.tsx
index 7e617fcea4..3b7d50a8f3 100644
--- a/services/web/frontend/js/features/ui/components/ol/ol-col.tsx
+++ b/services/web/frontend/js/features/ui/components/ol/ol-col.tsx
@@ -8,23 +8,51 @@ type OLColProps = React.ComponentProps<typeof Col> & {
 
 function OLCol(props: OLColProps) {
   const { bs3Props, ...rest } = props
-  const sizes = new Set(['xs', 'sm', 'md', 'lg', 'xl', 'xxl'])
 
   const getBs3Sizes = (obj: typeof rest) => {
-    return Object.entries(obj).reduce(
+    const bs5ToBs3SizeMap = {
+      xs: undefined,
+      sm: undefined,
+      md: 'sm',
+      lg: 'md',
+      xl: 'lg',
+      xxl: undefined,
+    } as const
+
+    const isBs5ToBs3SizeMapKey = (
+      key: string
+    ): key is keyof typeof bs5ToBs3SizeMap => {
+      return key in bs5ToBs3SizeMap
+    }
+
+    const sizes = Object.entries(obj).reduce(
       (prev, [key, value]) => {
-        if (sizes.has(key)) {
-          if (typeof value === 'object') {
-            prev[key] = value.span
-            prev[`${key}Offset`] = value.offset
-          } else {
-            prev[key] = value
+        if (isBs5ToBs3SizeMapKey(key)) {
+          const bs3Size = bs5ToBs3SizeMap[key]
+
+          if (bs3Size) {
+            if (typeof value === 'object') {
+              prev[bs3Size] = value.span
+              prev[`${bs3Size}Offset`] = value.offset
+            } else {
+              prev[bs3Size] = value
+            }
           }
         }
+
         return prev
       },
       {} as Record<string, (typeof rest)['xs']>
     )
+
+    // Add a default sizing for `col-xs-12` if no sizing is available
+    if (
+      !Object.keys(sizes).some(key => ['xs', 'sm', 'md', 'lg'].includes(key))
+    ) {
+      sizes.xs = 12
+    }
+
+    return sizes
   }
 
   const bs3ColProps: React.ComponentProps<typeof BS3Col> = {