From 6ee56438aaceedf16b4884864fc530c8beca1bca Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Wed, 3 Jun 2020 10:27:34 +0100 Subject: [PATCH 1/3] update to node 10.21.0 --- services/track-changes/.nvmrc | 2 +- services/track-changes/Dockerfile | 2 +- services/track-changes/docker-compose.yml | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/services/track-changes/.nvmrc b/services/track-changes/.nvmrc index 5b7269c0a9..b61c07ffdd 100644 --- a/services/track-changes/.nvmrc +++ b/services/track-changes/.nvmrc @@ -1 +1 @@ -10.19.0 +10.21.0 diff --git a/services/track-changes/Dockerfile b/services/track-changes/Dockerfile index c014691791..7b47fb9ee2 100644 --- a/services/track-changes/Dockerfile +++ b/services/track-changes/Dockerfile @@ -2,7 +2,7 @@ # Instead run bin/update_build_scripts from # https://github.com/sharelatex/sharelatex-dev-environment -FROM node:10.19.0 as base +FROM node:10.21.0 as base WORKDIR /app diff --git a/services/track-changes/docker-compose.yml b/services/track-changes/docker-compose.yml index 88bd224842..27652dedab 100644 --- a/services/track-changes/docker-compose.yml +++ b/services/track-changes/docker-compose.yml @@ -6,7 +6,7 @@ version: "2.3" services: test_unit: - image: node:10.19.0 + image: node:10.21.0 volumes: - .:/app working_dir: /app @@ -17,7 +17,7 @@ services: user: node test_acceptance: - image: node:10.19.0 + image: node:10.21.0 volumes: - .:/app working_dir: /app From bb3e562d8d4c0bb3f8cc5a1f99c62365e5825b62 Mon Sep 17 00:00:00 2001 From: Brian Gough Date: Wed, 3 Jun 2020 11:12:38 +0100 Subject: [PATCH 2/3] update buildscript.txt to node 10.21.0 --- services/track-changes/buildscript.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/track-changes/buildscript.txt b/services/track-changes/buildscript.txt index 977522bfba..1551e8fbf3 100644 --- a/services/track-changes/buildscript.txt +++ b/services/track-changes/buildscript.txt @@ -5,6 +5,6 @@ track-changes --env-add=AWS_BUCKET=bucket --env-pass-through= --language=es ---node-version=10.19.0 +--node-version=10.21.0 --public-repo=True --script-version=2.0.0 From 9baf54ac00fd581c20bf6e9770fc2d6ed92afa07 Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Wed, 3 Jun 2020 11:32:07 +0100 Subject: [PATCH 3/3] [misc] make: ignore a lint/format task failure --- services/track-changes/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/track-changes/Makefile b/services/track-changes/Makefile index e1b4843fea..b01ebbcbe0 100644 --- a/services/track-changes/Makefile +++ b/services/track-changes/Makefile @@ -17,13 +17,13 @@ clean: docker rmi gcr.io/overleaf-ops/$(PROJECT_NAME):$(BRANCH_NAME)-$(BUILD_NUMBER) format: - $(DOCKER_COMPOSE) run --rm test_unit npm run format + $(DOCKER_COMPOSE) run --rm test_unit npm run format || true format_fix: $(DOCKER_COMPOSE) run --rm test_unit npm run format:fix lint: - $(DOCKER_COMPOSE) run --rm test_unit npm run lint + $(DOCKER_COMPOSE) run --rm test_unit npm run lint || true test: format lint test_unit test_acceptance