github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-02-23 19:21:57 +00:00
Code Issues Projects Releases Packages Wiki Activity

rate limit on reconnection attempts (cursor/click)

Browse source
This commit is contained in:
Brian Gough 2016-10-31 15:32:01 +00:00
parent f894048292
commit 4da9008300
1 changed files with 23 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
services/web/public/coffee/ide/connection/ConnectionManager.coffee
View file

@ -36,16 +36,19 @@ define [], () ->
inactive_disconnect: false inactive_disconnect: false
@$scope.tryReconnectNow = () => @$scope.tryReconnectNow = () =>
@tryReconnect() # user manually requested reconnection via "Try now" button
@tryReconnectWithRateLimit({force:true})
@$scope.$on 'cursor:editor:update', () => @$scope.$on 'cursor:editor:update', () =>
@lastUserAction = new Date() # time of last edit @lastUserAction = new Date() # time of last edit
if !@connected if !@connected
@tryReconnect() # user is editing, try to reconnect
@tryReconnectWithRateLimit()
document.querySelector('body').addEventListener 'click', (e) => document.querySelector('body').addEventListener 'click', (e) =>
if !@connected and e.target.id != 'try-reconnect-now-button' if !@connected and e.target.id != 'try-reconnect-now-button'
@tryReconnect() # user is editing, try to reconnect
@tryReconnectWithRateLimit()
@ide.socket = io.connect null, @ide.socket = io.connect null,
reconnect: false reconnect: false
@ -210,8 +213,25 @@ define [], () ->
# use socket.io connect() here to make a single attempt, the # use socket.io connect() here to make a single attempt, the
# reconnect() method makes multiple attempts # reconnect() method makes multiple attempts
@ide.socket.socket.connect() @ide.socket.socket.connect()
# record the time of the last attempt to connect
@lastConnectionAttempt = new Date()
setTimeout (=> @startAutoReconnectCountdown() if !@connected), 2000 setTimeout (=> @startAutoReconnectCountdown() if !@connected), 2000
MIN_RETRY_INTERVAL: 1000 # ms
BACKGROUND_RETRY_INTERVAL : 30 * 1000 # ms
tryReconnectWithRateLimit: (options) ->
# bail out if the reconnect is already in progress
return if @$scope.connection?.reconnecting
# bail out if we are going to reconnect soon anyway
reconnectingSoon = @$scope.connection?.reconnection_countdown? and @$scope.connection.reconnection_countdown <= 5
clickedTryNow = options?.force # user requested reconnection
return if reconnectingSoon and not clickedTryNow
# bail out if we tried reconnecting recently
allowedInterval = if clickedTryNow then @MIN_RETRY_INTERVAL else @BACKGROUND_RETRY_INTERVAL
return if @lastConnectionAttempt? and new Date() - @lastConnectionAttempt < allowedInterval
@tryReconnect()
disconnectIfInactive: ()-> disconnectIfInactive: ()->
@userIsInactive = (new Date() - @lastUserAction) > @disconnectAfterMs @userIsInactive = (new Date() - @lastUserAction) > @disconnectAfterMs
if @userIsInactive and @connected if @userIsInactive and @connected