github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

[misc] WebsocketControllerTests: explicitly pass a cb to leaveProject

Browse source 
...and fix the stubbing of `io.sockets.clients`.

We were running the assertions prior to the actual completion of the
 leaveProject. Which in turn shadowed the broken test setup --
 `io.sockets.clients()` was returning the `this.clientsInRoom=[]` from a
 previous context.
This commit is contained in:
Jakob Ackermann 2020-06-29 17:15:29 +01:00
parent bea0e9beb7
commit 4d01c02946
1 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
services/real-time/test/unit/js/WebsocketControllerTests.js
View file

@ -42,6 +42,7 @@ describe('WebsocketController', function () {
leave: sinon.stub()
}
return (this.WebsocketController = SandboxedModule.require(modulePath, {
globals: { console },
requires: {
'./WebApiManager': (this.WebApiManager = {}),
'./AuthorizationManager': (this.AuthorizationManager = {}),
@ -393,9 +394,19 @@ describe('WebsocketController', function () {
})
describe('when the project is not empty', function () {
beforeEach(function () {
beforeEach(function (done) {
this.clientsInRoom = ['mock-remaining-client']
return this.WebsocketController.leaveProject(this.io, this.client)
this.io = {
sockets: {
clients: (room_id) => {
if (room_id !== this.project_id) {
throw 'expected room_id to be project_id'
}
return this.clientsInRoom
}
}
}
return this.WebsocketController.leaveProject(this.io, this.client, done)
})
return it('should not flush the project in the document updater', function () {