github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-10-17 21:05:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

Avoid loading ranges twice for overview panel (#19554)

Browse source 
GitOrigin-RevId: da8cc295fe672a97e76b93cc7e88dc1f6d3d044d
This commit is contained in:
Alf Eaton 2024-07-29 13:29:43 +01:00 committed by Copybot
parent 1a535acedd
commit 4c76667379
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
services/web/frontend/js/features/ide-react/context/review-panel/hooks/use-review-panel-state.ts
View file

@ -1497,17 +1497,6 @@ function useReviewPanelState(): ReviewPanel.ReviewPanelState {
}, [reviewPanelOpen])
const canRefreshRanges = useRef(false)
useEffect(() => {
if (subView === 'overview' && canRefreshRanges.current) {
canRefreshRanges.current = false
setIsOverviewLoading(true)
refreshRanges().finally(() => {
setIsOverviewLoading(false)
})
}
}, [subView, refreshRanges])
const prevSubView = useRef(subView)
const initializedPrevSubView = useRef(false)
useEffect(() => {
@ -1521,6 +1510,17 @@ function useReviewPanelState(): ReviewPanel.ReviewPanelState {
canRefreshRanges.current = true
}, [subView])
useEffect(() => {
if (subView === 'overview' && canRefreshRanges.current) {
canRefreshRanges.current = false
setIsOverviewLoading(true)
refreshRanges().finally(() => {
setIsOverviewLoading(false)
})
}
}, [subView, refreshRanges])
useEffect(() => {
if (subView === 'cur_file' && prevSubView.current === 'overview') {
dispatchReviewPanelEvent('overview-closed', subView)