mirror of
https://github.com/overleaf/overleaf.git
synced 2025-03-29 08:54:11 +00:00
Avoid loading ranges twice for overview panel (#19554)
GitOrigin-RevId: da8cc295fe672a97e76b93cc7e88dc1f6d3d044d
This commit is contained in:
parent
1a535acedd
commit
4c76667379
1 changed files with 11 additions and 11 deletions
|
@ -1497,17 +1497,6 @@ function useReviewPanelState(): ReviewPanel.ReviewPanelState {
|
||||||
}, [reviewPanelOpen])
|
}, [reviewPanelOpen])
|
||||||
|
|
||||||
const canRefreshRanges = useRef(false)
|
const canRefreshRanges = useRef(false)
|
||||||
useEffect(() => {
|
|
||||||
if (subView === 'overview' && canRefreshRanges.current) {
|
|
||||||
canRefreshRanges.current = false
|
|
||||||
|
|
||||||
setIsOverviewLoading(true)
|
|
||||||
refreshRanges().finally(() => {
|
|
||||||
setIsOverviewLoading(false)
|
|
||||||
})
|
|
||||||
}
|
|
||||||
}, [subView, refreshRanges])
|
|
||||||
|
|
||||||
const prevSubView = useRef(subView)
|
const prevSubView = useRef(subView)
|
||||||
const initializedPrevSubView = useRef(false)
|
const initializedPrevSubView = useRef(false)
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
|
@ -1521,6 +1510,17 @@ function useReviewPanelState(): ReviewPanel.ReviewPanelState {
|
||||||
canRefreshRanges.current = true
|
canRefreshRanges.current = true
|
||||||
}, [subView])
|
}, [subView])
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (subView === 'overview' && canRefreshRanges.current) {
|
||||||
|
canRefreshRanges.current = false
|
||||||
|
|
||||||
|
setIsOverviewLoading(true)
|
||||||
|
refreshRanges().finally(() => {
|
||||||
|
setIsOverviewLoading(false)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}, [subView, refreshRanges])
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
if (subView === 'cur_file' && prevSubView.current === 'overview') {
|
if (subView === 'cur_file' && prevSubView.current === 'overview') {
|
||||||
dispatchReviewPanelEvent('overview-closed', subView)
|
dispatchReviewPanelEvent('overview-closed', subView)
|
||||||
|
|
Loading…
Reference in a new issue