github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-12-17 23:31:14 -05:00
Code Issues Projects Releases Packages Wiki Activity

Remove deprecated event handlers, conditionally add the new ones in the Ace wrapper directive.

Browse source
This commit is contained in:
Paulo Reis 2016-11-17 10:51:17 +00:00
parent f170fd4b83
commit 4bba8e8977
2 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
services/web/public/coffee/ide/editor/directives/aceEditor.coffee
View file

@ -244,6 +244,8 @@ define [
scope.eventsBridge.emit "aceScrollbarVisibilityChanged", vRenderer.scrollBarV.isVisible, vRenderer.scrollBarV.width scope.eventsBridge.emit "aceScrollbarVisibilityChanged", vRenderer.scrollBarV.isVisible, vRenderer.scrollBarV.width
if scope.eventsBridge? if scope.eventsBridge?
editor.renderer.on "scrollbarVisibilityChanged", onScrollbarVisibilityChanged
scope.eventsBridge.on "externalScroll", (position) -> scope.eventsBridge.on "externalScroll", (position) ->
editor.getSession().setScrollTop(position) editor.getSession().setScrollTop(position)
@ -298,8 +300,8 @@ define [
# deletes and then inserts document content # deletes and then inserts document content
session.setAnnotations scope.annotations session.setAnnotations scope.annotations
session.on "changeScrollTop", onScroll if scope.eventsBridge?
editor.renderer.on "scrollbarVisibilityChanged", onScrollbarVisibilityChanged session.on "changeScrollTop", onScroll
setTimeout () -> setTimeout () ->
# Let any listeners init themselves # Let any listeners init themselves

4
services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee
View file

@ -19,10 +19,6 @@ define [
adding: false adding: false
content: "" content: ""
# DEPRECATED Used to communicate between Ace and reviewPanelSorted directive
$scope.scrollBindings =
reviewPanelEvents: new EventEmitter()
$scope.reviewPanelEventsBridge = new EventEmitter() $scope.reviewPanelEventsBridge = new EventEmitter()
changesTrackers = {} changesTrackers = {}