Remove deprecated event handlers, conditionally add the new ones in the Ace wrapper directive.

This commit is contained in:
Paulo Reis 2016-11-17 10:51:17 +00:00
parent f170fd4b83
commit 4bba8e8977
2 changed files with 5 additions and 7 deletions

View file

@ -244,6 +244,8 @@ define [
scope.eventsBridge.emit "aceScrollbarVisibilityChanged", vRenderer.scrollBarV.isVisible, vRenderer.scrollBarV.width
if scope.eventsBridge?
editor.renderer.on "scrollbarVisibilityChanged", onScrollbarVisibilityChanged
scope.eventsBridge.on "externalScroll", (position) ->
editor.getSession().setScrollTop(position)
@ -297,9 +299,9 @@ define [
# need to set annotations after attaching because attaching
# deletes and then inserts document content
session.setAnnotations scope.annotations
session.on "changeScrollTop", onScroll
editor.renderer.on "scrollbarVisibilityChanged", onScrollbarVisibilityChanged
if scope.eventsBridge?
session.on "changeScrollTop", onScroll
setTimeout () ->
# Let any listeners init themselves

View file

@ -19,10 +19,6 @@ define [
adding: false
content: ""
# DEPRECATED Used to communicate between Ace and reviewPanelSorted directive
$scope.scrollBindings =
reviewPanelEvents: new EventEmitter()
$scope.reviewPanelEventsBridge = new EventEmitter()
changesTrackers = {}