github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #10323 from overleaf/ae-pdf-dblclick-page

Browse source 
Ensure only one dblclick listener is attached to a PDF page

GitOrigin-RevId: cadaa2f3bbaba8c496a6ece698b2ba7f12f340c4
This commit is contained in:
Miguel Serrano 2022-11-07 11:51:07 +01:00 committed by Copybot
parent 900c5b29cb
commit 4a3fb3344b
1 changed files with 18 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/web/frontend/js/features/pdf-preview/components/pdf-js-viewer.js
View file

@ -192,6 +192,9 @@ function PdfJsViewer({ url, pdfFile }) {
const handleTextlayerrendered = textLayer => { const handleTextlayerrendered = textLayer => {
const pageElement = textLayer.source.textLayerDiv.closest('.page') const pageElement = textLayer.source.textLayerDiv.closest('.page')
if (!pageElement.dataset.listeningForDoubleClick) {
pageElement.dataset.listeningForDoubleClick = true
const doubleClickListener = event => { const doubleClickListener = event => {
const clickPosition = pdfJsWrapper.clickPosition( const clickPosition = pdfJsWrapper.clickPosition(
event, event,
@ -210,6 +213,7 @@ function PdfJsViewer({ url, pdfFile }) {
pageElement.addEventListener('dblclick', doubleClickListener) pageElement.addEventListener('dblclick', doubleClickListener)
} }
}
pdfJsWrapper.eventBus.on('textlayerrendered', handleTextlayerrendered) pdfJsWrapper.eventBus.on('textlayerrendered', handleTextlayerrendered)
return () => return () =>