From 4871d56725dc75a2e50360e370c517bb2ba3076e Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Mon, 9 Jan 2017 14:30:29 +0000 Subject: [PATCH] Isolate overview panel overrides. --- .../review-panel/controllers/ReviewPanelController.coffee | 7 ++----- .../web/public/stylesheets/app/editor/review-panel.less | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee index 70edf939ad..b311a5e0f1 100644 --- a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee +++ b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee @@ -55,11 +55,7 @@ define [ $reviewPanelEl.css "right", "#{ scrollbar.scrollbarWidth }px" else $reviewPanelEl.css "right", "0" - - $scope.$watch "reviewPanel.subView", (subView) -> - return if !subView? - updateScrollbar() - + $scope.$watch "ui.reviewPanelOpen", (open) -> return if !open? if !open @@ -72,6 +68,7 @@ define [ $scope.$watch "reviewPanel.subView", (view) -> return if !view? + updateScrollbar() if view == $scope.SubViews.OVERVIEW refreshOverviewPanel() diff --git a/services/web/public/stylesheets/app/editor/review-panel.less b/services/web/public/stylesheets/app/editor/review-panel.less index 204191f418..6219ec2e59 100644 --- a/services/web/public/stylesheets/app/editor/review-panel.less +++ b/services/web/public/stylesheets/app/editor/review-panel.less @@ -137,7 +137,6 @@ bottom: 0; } - .rp-state-overview & { flex-grow: 2; overflow-y: auto; @@ -314,7 +313,7 @@ .rp-entry-actions { display: flex; - .rp-state-overview & { + .rp-entry-list .rp-state-overview & { display: none; } } @@ -336,14 +335,12 @@ line-height: 1.4; border-bottom: solid 1px @rp-border-grey; - - &:last-child { margin-bottom: 2px; border-bottom-width: 0; } - .rp-state-overview & { + .rp-entry-list .rp-state-overview & { margin: 4px 5px; &:first-child {