github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-01-28 22:31:30 +00:00
Code Issues Projects Releases Packages Wiki Activity

Should not AB test when signed up before 2018-06-06

Browse source
This commit is contained in:
Jessica Lawshe 2018-06-05 16:04:20 -05:00
parent 679d91c4d2
commit 484ee9ad61
3 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/app/coffee/Features/Subscription/SubscriptionController.coffee
View file

@ -30,7 +30,7 @@ module.exports = SubscriptionController =
plans: plans
gaExperiments: Settings.gaExperiments.plansPage
recomendedCurrency:recomendedCurrency
shouldABTestPlans: currentUser == null or (currentUser?.signUpDate? and currentUser.signUpDate >= (new Date('2016-10-27')))
shouldABTestPlans: currentUser == null or (currentUser?.signUpDate? and currentUser.signUpDate >= '2018-06-06')
planFeatures: planFeatures
user_id = AuthenticationController.getLoggedInUserId(req)
if user_id?

2
services/web/public/coffee/ide.coffee
View file

@ -88,7 +88,7 @@ define [
$scope.user = window.user
$scope.shouldABTestPlans = false
if $scope.user.signUpDate >= '2016-10-27'
if $scope.user.signUpDate >= '2018-06-06'
$scope.shouldABTestPlans = true
$scope.settings = window.userSettings

6
services/web/test/unit/coffee/Subscription/SubscriptionControllerTests.coffee
View file

@ -99,7 +99,11 @@ describe "SubscriptionController", ->
@UserGetter.getUser.callCount.should.equal 1
done()
it 'should decide not to AB test the plans when signed up before 2016-10-27', (done) ->
it 'should decide not to AB test the plans when signed up before 2018-06-06', (done) ->
# Users before we introduce the test may have already seen the old variant,
# and so may react positively to a change rather than the variant itself.
# So it's more likely to skew in favour of the change
# just because change makes things 'fresh'
@res.renderedVariables.shouldABTestPlans.should.equal false
done()