From 451c910fe35428df33f62a2072dbb6f3acac46d8 Mon Sep 17 00:00:00 2001 From: Alf Eaton Date: Fri, 15 Jul 2022 11:05:34 +0100 Subject: [PATCH] Merge pull request #8837 from overleaf/mj-fix-default-group-account-translation Rephrase "Group Account" to "Group Subscription" on subscription management page GitOrigin-RevId: 899a6f27fbe7533b93345b7c27a4d427d40c5e1a --- .../Features/UserMembership/UserMembershipEntityConfigs.js | 4 ++-- services/web/locales/en.json | 2 +- .../unit/src/UserMembership/UserMembershipControllerTests.js | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/services/web/app/src/Features/UserMembership/UserMembershipEntityConfigs.js b/services/web/app/src/Features/UserMembership/UserMembershipEntityConfigs.js index e74b32d7ad..7549049a9d 100644 --- a/services/web/app/src/Features/UserMembership/UserMembershipEntityConfigs.js +++ b/services/web/app/src/Features/UserMembership/UserMembershipEntityConfigs.js @@ -14,7 +14,7 @@ module.exports = { groupPlan: true, }, translations: { - title: 'group_account', + title: 'group_subscription', subtitle: 'members_management', remove: 'remove_from_group', }, @@ -53,7 +53,7 @@ module.exports = { groupPlan: true, }, translations: { - title: 'group_account', + title: 'group_subscription', subtitle: 'managers_management', remove: 'remove_manager', }, diff --git a/services/web/locales/en.json b/services/web/locales/en.json index e19f4a541b..df1f2282b1 100644 --- a/services/web/locales/en.json +++ b/services/web/locales/en.json @@ -1201,7 +1201,7 @@ "loading_billing_form": "Loading billing details form", "you_have_added_x_of_group_size_y": "You have added <0>__addedUsersSize__ of <1>__groupSize__ available members", "remove_from_group": "Remove from group", - "group_account": "Group Account", + "group_subscription": "Group Subscription", "registered": "Registered", "no_members": "No members", "add_more_members": "Add more members", diff --git a/services/web/test/unit/src/UserMembership/UserMembershipControllerTests.js b/services/web/test/unit/src/UserMembership/UserMembershipControllerTests.js index b71ebbacf2..bb61d420dc 100644 --- a/services/web/test/unit/src/UserMembership/UserMembershipControllerTests.js +++ b/services/web/test/unit/src/UserMembership/UserMembershipControllerTests.js @@ -107,7 +107,7 @@ describe('UserMembershipController', function () { expect(viewPath).to.equal('user_membership/index') expect(viewParams.users).to.deep.equal(this.users) expect(viewParams.groupSize).to.equal(this.subscription.membersLimit) - expect(viewParams.translations.title).to.equal('group_account') + expect(viewParams.translations.title).to.equal('group_subscription') expect(viewParams.paths.addMember).to.equal( `/manage/groups/${this.subscription._id}/invites` ) @@ -122,7 +122,7 @@ describe('UserMembershipController', function () { render: (viewPath, viewParams) => { expect(viewPath).to.equal('user_membership/index') expect(viewParams.groupSize).to.equal(undefined) - expect(viewParams.translations.title).to.equal('group_account') + expect(viewParams.translations.title).to.equal('group_subscription') expect(viewParams.translations.subtitle).to.equal( 'managers_management' )