mirror of
https://github.com/overleaf/overleaf.git
synced 2024-11-14 20:40:17 -05:00
Manually force blur on submitting an edited message (#21333)
* Return focus to parent entry element after message is edited * Revert "Return focus to parent entry element after message is edited" This reverts commit 96234a666e7e7c17b99a23a8a92ea030efe6083f. * Manually force blur on submitting an edited message * Show review panel entry header when editing comment (#21397) * Show review panel entry header when editing comment * edit comment spacing * hide comment options when editing --------- Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com> GitOrigin-RevId: 66a8d1ed772cf91ea0f086bd08cdabaeb7456956
This commit is contained in:
parent
40ed104bce
commit
44b2ca1830
3 changed files with 36 additions and 31 deletions
|
@ -51,32 +51,6 @@ export const ReviewPanelMessage: FC<{
|
|||
setDeleting(false)
|
||||
}, [onDelete])
|
||||
|
||||
if (editing) {
|
||||
return (
|
||||
<div>
|
||||
<AutoExpandingTextArea
|
||||
className="review-panel-comment-input"
|
||||
onBlur={handleSubmit}
|
||||
onChange={e => setContent(e.target.value)}
|
||||
onKeyDown={e => {
|
||||
if (
|
||||
e.key === 'Enter' &&
|
||||
!e.shiftKey &&
|
||||
!e.ctrlKey &&
|
||||
!e.metaKey &&
|
||||
content
|
||||
) {
|
||||
e.preventDefault()
|
||||
handleSubmit()
|
||||
}
|
||||
}}
|
||||
value={content}
|
||||
autoFocus // eslint-disable-line jsx-a11y/no-autofocus
|
||||
/>
|
||||
</div>
|
||||
)
|
||||
}
|
||||
|
||||
return (
|
||||
<div className="review-panel-comment">
|
||||
<div className="review-panel-entry-header">
|
||||
|
@ -90,7 +64,7 @@ export const ReviewPanelMessage: FC<{
|
|||
</div>
|
||||
|
||||
<div className="review-panel-entry-actions">
|
||||
{!isReply && !isThreadResolved && (
|
||||
{!editing && !isReply && !isThreadResolved && (
|
||||
<OLTooltip
|
||||
id="resolve-thread"
|
||||
overlayProps={{ placement: 'bottom' }}
|
||||
|
@ -107,7 +81,7 @@ export const ReviewPanelMessage: FC<{
|
|||
</OLTooltip>
|
||||
)}
|
||||
|
||||
{!isThreadResolved && (
|
||||
{!editing && !isThreadResolved && (
|
||||
<ReviewPanelCommentOptions
|
||||
belongsToCurrentUser={user.id === message.user.id}
|
||||
onEdit={handleEditOption}
|
||||
|
@ -117,9 +91,32 @@ export const ReviewPanelMessage: FC<{
|
|||
)}
|
||||
</div>
|
||||
</div>
|
||||
{editing ? (
|
||||
<AutoExpandingTextArea
|
||||
className="review-panel-comment-input review-panel-comment-edit"
|
||||
onBlur={handleSubmit}
|
||||
onChange={e => setContent(e.target.value)}
|
||||
onKeyDown={e => {
|
||||
if (
|
||||
e.key === 'Enter' &&
|
||||
!e.shiftKey &&
|
||||
!e.ctrlKey &&
|
||||
!e.metaKey &&
|
||||
content
|
||||
) {
|
||||
e.preventDefault()
|
||||
;(e.target as HTMLTextAreaElement).blur()
|
||||
}
|
||||
}}
|
||||
value={content}
|
||||
autoFocus // eslint-disable-line jsx-a11y/no-autofocus
|
||||
/>
|
||||
) : (
|
||||
<ExpandableContent className="review-panel-comment-body">
|
||||
{message.content}
|
||||
</ExpandableContent>
|
||||
)}
|
||||
|
||||
{deleting && (
|
||||
<ReviewPanelDeleteCommentModal
|
||||
onHide={hideDeleteModal}
|
||||
|
|
|
@ -391,6 +391,10 @@
|
|||
max-height: 400px;
|
||||
}
|
||||
|
||||
.review-panel-comment-edit {
|
||||
margin-top: var(--spacing-03);
|
||||
}
|
||||
|
||||
.review-panel-empty-state {
|
||||
position: fixed;
|
||||
width: var(--review-panel-width);
|
||||
|
|
|
@ -396,6 +396,10 @@
|
|||
max-height: 400px;
|
||||
}
|
||||
|
||||
.review-panel-comment-edit {
|
||||
margin-top: var(--spacing-03);
|
||||
}
|
||||
|
||||
.review-panel-empty-state {
|
||||
position: fixed;
|
||||
width: var(--review-panel-width);
|
||||
|
|
Loading…
Reference in a new issue