github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-20 15:05:43 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #15553 from overleaf/as-remove-scroll-tracking-trigger

Browse source 
Proposal: Remove scroll trigger for event tracking
GitOrigin-RevId: 8d27b5a2ad5d1f88600c2a193c0ad0dc44ca9aa2
This commit is contained in:
Jessica Lawshe 2023-11-06 09:28:25 -06:00 • committed by Copybot
parent 780673ed31
commit 41ec69a5ea
1 changed files with 4 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
services/web/frontend/js/features/event-tracking/index.js
View file

@ -1,15 +1,5 @@
import _ from 'lodash'
import * as eventTracking from '../../infrastructure/event-tracking'
function isInViewport(element) {
const elTop = $(element).offset().top
const elBtm = elTop + $(element).outerHeight()
const viewportTop = $(window).scrollTop()
const viewportBtm = viewportTop + $(window).height()
return elBtm > viewportTop && elTop < viewportBtm
}
import { debugConsole } from '@/utils/debugging'
function setupEventTracking(el) {
const key = el.getAttribute('event-tracking')
@ -46,7 +36,6 @@ function setupEventTracking(el) {
}
}
let handler
let timer
let timeoutAmt = 500
switch (trigger) {
@ -65,17 +54,9 @@ function setupEventTracking(el) {
})
el.addEventListener('mouseleave', () => clearTimeout(timer))
break
case 'scroll':
handler = _.throttle(() => {
if (isInViewport(el)) {
submit()
window.removeEventListener('scroll', handler)
window.removeEventListener('resize', handler)
}
}, 500)
window.addEventListener('scroll', handler)
window.addEventListener('resize', handler)
break
default:
debugConsole.error(`unsupported event tracking action: ${trigger}`)
}
}