github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-06 07:02:47 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix a daft mistake, blank out whitelisted words, rather than remove

Browse source 
This had caused an issue whereby spelling-mistakes would be highlighted
on the wrong word in the client. This was a function of how many whitelisted
words had already occured in the sequence. An off-by-n error.
This commit is contained in:
Shane Kilkelly 2017-06-23 09:14:39 +01:00
parent 00358aa14b
commit 407283ee3c
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
services/spelling/app/coffee/SpellingAPIManager.coffee
View file

@ -23,8 +23,12 @@ module.exports = SpellingAPIManager =
ASpell.checkWords lang, words, (error, misspellings) ->
callback error, misspellings: misspellings
wordsToCheck = (request.words || []).filter (word) ->
SpellingAPIManager.wordWhitelist.indexOf(word) == -1
wordsToCheck = (request.words || []).map (word) ->
# blank out whitelisted words
if SpellingAPIManager.wordWhitelist.indexOf(word) == -1
word
else
'...'
if token?
LearnedWordsManager.getLearnedWords token, (error, learnedWords) ->

2
services/spelling/test/unit/coffee/SpellingAPIManagerTests.coffee
View file

@ -89,7 +89,7 @@ describe "SpellingAPIManager", ->
@SpellingAPIManager.runRequest @token, words: @words, (error, @result) => done()
it 'should ignore the white-listed word', ->
expect(@ASpell.checkWords.lastCall.args[1]).to.deep.equal ["One", "Two"]
expect(@ASpell.checkWords.lastCall.args[1]).to.deep.equal ["One", "...", "Two"]
describe "learnWord", ->
describe "without a token", ->