From 3f073c2341c7519015c560f722ac84d59012202f Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Tue, 20 Mar 2018 16:06:44 +0000 Subject: [PATCH] Rename attributes and vars for clarity --- services/web/app/views/project/editor.pug | 4 ++-- services/web/app/views/project/editor/editor.pug | 4 ++-- .../web/public/coffee/ide/directives/layout.coffee | 12 ++++++------ 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/services/web/app/views/project/editor.pug b/services/web/app/views/project/editor.pug index ccedf23cc6..c2dabadb3e 100644 --- a/services/web/app/views/project/editor.pug +++ b/services/web/app/views/project/editor.pug @@ -63,8 +63,8 @@ block content resize-on="layout:chat:resize", minimum-restore-size-west="130" custom-toggler-pane="'west'" - custom-toggler-tooltip-open="'Click to open the file tree'" - custom-toggler-tooltip-close="'Click to close the file tree'" + custom-toggler-msg-when-open="'Click to close the file tree'" + custom-toggler-msg-when-closed="'Click to open the file tree'" ) .ui-layout-west include ./editor/file-tree diff --git a/services/web/app/views/project/editor/editor.pug b/services/web/app/views/project/editor/editor.pug index 48e081fec1..a2368b98e1 100644 --- a/services/web/app/views/project/editor/editor.pug +++ b/services/web/app/views/project/editor/editor.pug @@ -9,8 +9,8 @@ div.full-size( minimum-restore-size-east="300" allow-overflow-on="'center'" custom-toggler-pane="'east'" - custom-toggler-tooltip-open="'Click to open the PDF'" - custom-toggler-tooltip-close="'Click to close the PDF'" + custom-toggler-msg-when-open="'Click to close the PDF'" + custom-toggler-msg-when-closed="'Click to open the PDF'" ) .ui-layout-center( ng-controller="ReviewPanelController", diff --git a/services/web/public/coffee/ide/directives/layout.coffee b/services/web/public/coffee/ide/directives/layout.coffee index 402143e213..9e9fae5e99 100644 --- a/services/web/public/coffee/ide/directives/layout.coffee +++ b/services/web/public/coffee/ide/directives/layout.coffee @@ -9,9 +9,9 @@ define [ name = attrs.layout customTogglerPane = scope.$eval(attrs.customTogglerPane) - customTogglerTooltipOpen = scope.$eval(attrs.customTogglerTooltipOpen) - customTogglerTooltipClose = scope.$eval(attrs.customTogglerTooltipClose) - hasCustomToggler = customTogglerPane? and customTogglerTooltipOpen? and customTogglerTooltipClose? + customTogglerMsgWhenOpen = scope.$eval(attrs.customTogglerMsgWhenOpen) + customTogglerMsgWhenClosed = scope.$eval(attrs.customTogglerMsgWhenClosed) + hasCustomToggler = customTogglerPane? and customTogglerMsgWhenOpen? and customTogglerMsgWhenClosed? if attrs.spacingOpen? spacingOpen = parseInt(attrs.spacingOpen, 10) @@ -124,8 +124,8 @@ define [ customTogglerScope.isOpen = false console.log customTogglerScope.isOpen - customTogglerScope.tooltipMsgOpen = customTogglerTooltipOpen - customTogglerScope.tooltipMsgClose = customTogglerTooltipClose + customTogglerScope.tooltipMsgWhenOpen = customTogglerMsgWhenOpen + customTogglerScope.tooltipMsgWhenClosed = customTogglerMsgWhenClosed customTogglerScope.tooltipPlacement = if customTogglerPane == "east" then "left" else "right" customTogglerScope.handleClick = () -> @@ -135,7 +135,7 @@ define [ ")(customTogglerScope)