From 25448bfef41c3c14a3dd20bdcbc021d75f7a9e2c Mon Sep 17 00:00:00 2001 From: Eric Mc Sween Date: Wed, 18 Mar 2020 08:41:11 -0400 Subject: [PATCH 1/2] Downgrade all request logs to INFO Commit 9056143fe36f1347a1ff985ef8592a1de7d798dd added logic to log requests with different error levels depending on the status code. The intention was to make the 5xx and 4xx requests stand out in Stackdriver. Unfortunately, this also creates a lot of noise in Sentry since we log the errors separately from the requests. This commit brings back the former behaviour of logging all requests at the INFO level. We can revisit this if we integrate the strategy implemented in filestore of logging once per request. --- libraries/metrics/http.coffee | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/libraries/metrics/http.coffee b/libraries/metrics/http.coffee index e3097c8c72..db7d56b2da 100644 --- a/libraries/metrics/http.coffee +++ b/libraries/metrics/http.coffee @@ -49,10 +49,5 @@ module.exports.monitor = (logger) -> "content-length": res._headers?["content-length"] statusCode: res.statusCode "response-time": responseTimeMs - if res.statusCode >= 500 - logger.error(info, "%s %s", req.method, reqUrl) - else if res.statusCode >= 400 and res.statusCode < 500 - logger.warn(info, "%s %s", req.method, reqUrl) - else - logger.info(info, "%s %s", req.method, reqUrl) + logger.info(info, "%s %s", req.method, reqUrl) next() From a17843f3bf372465d2b61a690f962b8eaa1987f1 Mon Sep 17 00:00:00 2001 From: Eric Mc Sween Date: Fri, 20 Mar 2020 07:47:05 -0400 Subject: [PATCH 2/2] 2.6.1 --- libraries/metrics/package-lock.json | 2 +- libraries/metrics/package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/metrics/package-lock.json b/libraries/metrics/package-lock.json index 5879ca0dbb..6e06da433b 100644 --- a/libraries/metrics/package-lock.json +++ b/libraries/metrics/package-lock.json @@ -1,6 +1,6 @@ { "name": "metrics-sharelatex", - "version": "2.5.0", + "version": "2.6.1", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/libraries/metrics/package.json b/libraries/metrics/package.json index de6c86b37e..9bf50d9c35 100644 --- a/libraries/metrics/package.json +++ b/libraries/metrics/package.json @@ -1,6 +1,6 @@ { "name": "metrics-sharelatex", - "version": "2.6.0", + "version": "2.6.1", "description": "A drop-in metrics and monitoring module for node.js apps", "repository": { "type": "git",