github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge branch 'ja-scroll-review-panel-past-ace' into ja-hide-offscreen-review-panel-entries

Browse source
This commit is contained in:
James Allen 2017-02-20 16:24:26 +01:00
commit 3af7cdf0a9
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/public/coffee/ide/review-panel/directives/reviewPanelSorted.coffee
View file

@ -33,6 +33,7 @@ define [
entry.$layout_el = entry.$box_el
else
entry.$layout_el = entry.$indicator_el
entry.height = entry.$layout_el.height() # Do all of our DOM reads first for perfomance, see http://wilsonpage.co.uk/preventing-layout-thrashing/
entries.push entry
entries.sort (a,b) -> a.scope.entry.offset - b.scope.entry.offset
@ -69,7 +70,7 @@ define [
previousBottom = focused_entry_top + focused_entry.$layout_el.height()
for entry in entries_after
original_top = entry.scope.entry.screenPos.y
height = entry.$layout_el.height()
height = entry.height
top = Math.max(original_top, previousBottom + PADDING)
previousBottom = top + height
entry.$box_el.css(top: top)
@ -83,7 +84,7 @@ define [
entries_before.reverse() # Work through backwards, starting with the one just above
for entry, i in entries_before
original_top = entry.scope.entry.screenPos.y
height = entry.$layout_el.height()
height = entry.height
original_bottom = original_top + height
bottom = Math.min(original_bottom, previousTop - PADDING)
top = bottom - height