From 3aa6346ab3963489981aa44523dca27ffd805047 Mon Sep 17 00:00:00 2001
From: Jimmy Domagala-Tang <Jimmy.Domagala-Tang@overleaf.com>
Date: Tue, 12 Sep 2023 11:30:02 -0400
Subject: [PATCH] Merge pull request #14674 from
 overleaf/jdt-prevent-menu-item-drags
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

feat: force all menuitems to be undraggable, and make home button und…
GitOrigin-RevId: 5b04a07aaca43b1eff8b50958d74356663b6d416
---
 .../components/back-to-projects-button.tsx                      | 1 +
 .../pdf-preview/components/pdf-hybrid-download-button.tsx       | 1 +
 services/web/frontend/js/shared/components/split-menu.tsx       | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/services/web/frontend/js/features/editor-navigation-toolbar/components/back-to-projects-button.tsx b/services/web/frontend/js/features/editor-navigation-toolbar/components/back-to-projects-button.tsx
index 3a53c856ba..9fb9968d19 100644
--- a/services/web/frontend/js/features/editor-navigation-toolbar/components/back-to-projects-button.tsx
+++ b/services/web/frontend/js/features/editor-navigation-toolbar/components/back-to-projects-button.tsx
@@ -15,6 +15,7 @@ function BackToProjectsButton() {
       <div className="toolbar-item">
         <a
           className="btn btn-full-height"
+          draggable="false"
           href="/project"
           onClick={() => {
             eventTracking.sendMB('navigation-clicked-home')
diff --git a/services/web/frontend/js/features/pdf-preview/components/pdf-hybrid-download-button.tsx b/services/web/frontend/js/features/pdf-preview/components/pdf-hybrid-download-button.tsx
index 6633b59892..bc3501693e 100644
--- a/services/web/frontend/js/features/pdf-preview/components/pdf-hybrid-download-button.tsx
+++ b/services/web/frontend/js/features/pdf-preview/components/pdf-hybrid-download-button.tsx
@@ -32,6 +32,7 @@ function PdfHybridDownloadButton() {
       <Button
         onClick={handleOnClick}
         bsStyle="link"
+        draggable="false"
         disabled={!pdfDownloadUrl}
         download
         href={pdfDownloadUrl || '#'}
diff --git a/services/web/frontend/js/shared/components/split-menu.tsx b/services/web/frontend/js/shared/components/split-menu.tsx
index da5fb8b13b..33fd4c3188 100644
--- a/services/web/frontend/js/shared/components/split-menu.tsx
+++ b/services/web/frontend/js/shared/components/split-menu.tsx
@@ -138,7 +138,7 @@ function SplitMenuButton({
 }
 
 function SplitMenuItem(props: MenuItemProps) {
-  return <MenuItem {...props} />
+  return <MenuItem {...props} draggable="false" />
 }
 
 SplitMenu.Item = SplitMenuItem