From 37817f89f4724c17d7a45b128371ce410c2ba3a2 Mon Sep 17 00:00:00 2001 From: Jimmy Domagala-Tang Date: Wed, 1 Nov 2023 10:22:05 -0400 Subject: [PATCH] Merge pull request #15295 from overleaf/jdt-subs-tbl-tab-access Add subscription table icons to the tab index GitOrigin-RevId: 1585cf2c7a114a9cae78c5d4bfbd888756aacf43 --- services/web/app/views/subscriptions/plans/_mixins.pug | 6 +++++- .../web/app/views/subscriptions/plans/_mixins_nudge.pug | 5 ++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/services/web/app/views/subscriptions/plans/_mixins.pug b/services/web/app/views/subscriptions/plans/_mixins.pug index be80e3e684..5b8abed766 100644 --- a/services/web/app/views/subscriptions/plans/_mixins.pug +++ b/services/web/app/views/subscriptions/plans/_mixins.pug @@ -78,7 +78,7 @@ mixin plans_v2_table(period, config) data-toggle="tooltip" title=translate(featuresPerSection.dividerInfo), data-placement="top" -) + ) //- will only appear on screen width < 768px (using CSS) span.plans-v2-table-divider-learn-more-container span ( @@ -88,6 +88,7 @@ mixin plans_v2_table(period, config) data-placement="top" ) #{translate("learn_more_lowercase")} span ) + span.sr-only #{translate(featuresPerSection.dividerInfo)} for feature, featureIndex in featuresPerSection.items unless !showNewCompileTimeoutVariant && feature.feature === 'compile_servers' tr( @@ -119,6 +120,7 @@ mixin plans_v2_table(period, config) data-placement="top" ) #{translate("learn_more_lowercase")} span ) + span.sr-only #{translate("compile_timeout_short_info_basic")} else i.fa.fa-question-circle.plans-v2-table-feature-name-question-icon( data-toggle="tooltip" @@ -134,6 +136,7 @@ mixin plans_v2_table(period, config) data-placement="top" ) #{translate("learn_more_lowercase")} span ) + span.sr-only #{translate(feature.info)} else | #{translate(feature.feature)} for plan, planIndex in Object.keys(feature.plans) @@ -415,6 +418,7 @@ mixin group_plans_license_picker() data-placement="bottom" ) #{translate("learn_more_lowercase")} span ) + span.sr-only #{translate("apply_educational_discount_info")} mixin btn_buy_individual(highlighted, discountHighlighted, eventTrackingKey, subscriptionPlan, period) a.btn.plans-v2-table-btn-buy( diff --git a/services/web/app/views/subscriptions/plans/_mixins_nudge.pug b/services/web/app/views/subscriptions/plans/_mixins_nudge.pug index ebe52fba76..702a21eade 100644 --- a/services/web/app/views/subscriptions/plans/_mixins_nudge.pug +++ b/services/web/app/views/subscriptions/plans/_mixins_nudge.pug @@ -78,7 +78,7 @@ mixin plans_v2_table(period, config) data-toggle="tooltip" title=translate(featuresPerSection.dividerInfo), data-placement="top" -) + ) //- will only appear on screen width < 768px (using CSS) span.plans-v2-table-divider-learn-more-container span ( @@ -88,6 +88,7 @@ mixin plans_v2_table(period, config) data-placement="top" ) #{translate("learn_more_lowercase")} span ) + span.sr-only #{translate(featuresPerSection.dividerInfo)} for feature, featureIndex in featuresPerSection.items tr( class=(featureIndex === (featuresPerSection.items.length - 1) ? `plans-v2-table-row-last-row-per-section cols-${maxColumn}` : `cols-${maxColumn}`) @@ -117,6 +118,7 @@ mixin plans_v2_table(period, config) data-placement="top" ) #{translate("learn_more_lowercase")} span ) + span.sr-only #{translate(feature.info)} else | #{translate(feature.feature)} for plan, planIndex in Object.keys(feature.plans) @@ -381,6 +383,7 @@ mixin group_plans_license_picker() data-placement="bottom" ) #{translate("learn_more_lowercase")} span ) + span.sr-only #{translate("apply_educational_discount_info")} mixin btn_buy_individual(highlighted, discountHighlighted, eventTrackingKey, subscriptionPlan, period) a.btn.plans-v2-table-btn-buy(