github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1 from overleaf/catching-null-pointer-exceptions

Browse source 
Loggin API response in order to figure out the use case for errors
This commit is contained in:
John Lees-Miller 2015-09-24 13:45:01 +01:00
commit 3635257cac
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/snapshot/push/PushResult.java
View file

@ -5,6 +5,7 @@ import com.google.gson.JsonObject;
import uk.ac.ic.wlgitbridge.snapshot.base.Result; import uk.ac.ic.wlgitbridge.snapshot.base.Result;
import uk.ac.ic.wlgitbridge.snapshot.base.Request; import uk.ac.ic.wlgitbridge.snapshot.base.Request;
import uk.ac.ic.wlgitbridge.snapshot.exception.FailedConnectionException; import uk.ac.ic.wlgitbridge.snapshot.exception.FailedConnectionException;
import uk.ac.ic.wlgitbridge.util.Util;
/** /**
* Created by Winston on 16/11/14. * Created by Winston on 16/11/14.
@ -28,8 +29,16 @@ public class PushResult extends Result {
@Override @Override
public void fromJSON(JsonElement json) { public void fromJSON(JsonElement json) {
JsonObject responseObject = json.getAsJsonObject(); String code;
String code = responseObject.get("code").getAsString(); try {
JsonObject responseObject = json.getAsJsonObject();
code = responseObject.get("code").getAsString();
} catch (Exception e) {
Util.serr("Unexpected response from API:");
Util.serr(json.toString());
Util.serr("End of response");
throw e;
}
if (code.equals("accepted")) { if (code.equals("accepted")) {
success = true; success = true;
} else if (code.equals("outOfDate")) { } else if (code.equals("outOfDate")) {
@ -38,5 +47,4 @@ public class PushResult extends Result {
throw new RuntimeException(); throw new RuntimeException();
} }
} }
} }