diff --git a/services/web/app/coffee/Features/Project/ProjectEditorHandler.coffee b/services/web/app/coffee/Features/Project/ProjectEditorHandler.coffee index e25ff29b28..37878fae09 100644 --- a/services/web/app/coffee/Features/Project/ProjectEditorHandler.coffee +++ b/services/web/app/coffee/Features/Project/ProjectEditorHandler.coffee @@ -20,10 +20,10 @@ module.exports = ProjectEditorHandler = if !result.invites? result.invites = [] - hasTrackChanges = false + trackChangesVisible = false for member in members if member.privilegeLevel == "owner" and member.user?.featureSwitches?.track_changes - hasTrackChanges = true + trackChangesVisible = true {owner, ownerFeatures, members} = @buildOwnerAndMembersViews(members) result.owner = owner @@ -37,7 +37,8 @@ module.exports = ProjectEditorHandler = compileGroup:"standard" templates: false references: false - trackChanges: hasTrackChanges + trackChanges: true # TODO: Set this to false to make track changes a paid feature + trackChangesVisible: trackChangesVisible # TODO: Get this from the beta flag when going to public beta }) return result diff --git a/services/web/app/views/project/editor/editor.pug b/services/web/app/views/project/editor/editor.pug index 98a2840069..9924fe1221 100644 --- a/services/web/app/views/project/editor/editor.pug +++ b/services/web/app/views/project/editor/editor.pug @@ -53,7 +53,7 @@ div.full-size( syntax-validation="settings.syntaxValidation", review-panel="reviewPanel", events-bridge="reviewPanelEventsBridge" - track-changes-enabled="project.features.trackChanges", + track-changes-enabled="project.features.trackChangesVisible", track-changes= "editor.trackChanges", doc-id="editor.open_doc_id" renderer-data="reviewPanel.rendererData" diff --git a/services/web/app/views/project/editor/header.pug b/services/web/app/views/project/editor/header.pug index 475ba1da52..85397fa83f 100644 --- a/services/web/app/views/project/editor/header.pug +++ b/services/web/app/views/project/editor/header.pug @@ -87,7 +87,7 @@ header.toolbar.toolbar-header.toolbar-with-labels( a.btn.btn-full-height( href, - ng-if="project.features.trackChanges", + ng-if="project.features.trackChangesVisible", ng-class="{ active: ui.reviewPanelOpen }" ng-click="toggleReviewPanel()" ) diff --git a/services/web/app/views/project/editor/review-panel.pug b/services/web/app/views/project/editor/review-panel.pug index 23857b4e4b..512e9e2b59 100644 --- a/services/web/app/views/project/editor/review-panel.pug +++ b/services/web/app/views/project/editor/review-panel.pug @@ -29,7 +29,7 @@ ng-if="editor.wantTrackChanges == editor.trackChanges" ng-model="editor.wantTrackChanges" on-toggle="toggleTrackChanges" - disabled="!project.features.hasTrackChanges" + disabled="!project.features.trackChanges" on-disabled-click="openTrackChangesUpgradeModal" ) span.review-panel-toolbar-label.review-panel-toolbar-label-disabled(ng-if="!permissions.write") diff --git a/services/web/config/settings.defaults.coffee b/services/web/config/settings.defaults.coffee index 8e503801f9..b24c2568ab 100644 --- a/services/web/config/settings.defaults.coffee +++ b/services/web/config/settings.defaults.coffee @@ -179,6 +179,7 @@ module.exports = settings = compileGroup: "standard" references: true templates: true + trackChanges: true plans: plans = [{ planCode: "personal" diff --git a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee index 368429a9d7..e7290e3ad4 100644 --- a/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee +++ b/services/web/public/coffee/ide/review-panel/controllers/ReviewPanelController.coffee @@ -7,10 +7,6 @@ define [ App.controller "ReviewPanelController", ($scope, $element, ide, $timeout, $http, $modal, event_tracking) -> $reviewPanelEl = $element.find "#review-panel" - # TODO Mocked feature flag, remove. - $scope.$on "project:joined", () -> - $scope.project.features.hasTrackChanges = true - $scope.SubViews = CUR_FILE : "cur_file" OVERVIEW : "overview" @@ -435,7 +431,7 @@ define [ ide.editorManager.openDocId(doc_id, { gotoOffset: entry.offset }) $scope.toggleTrackChanges = (value) -> - if $scope.project.features.hasTrackChanges + if $scope.project.features.trackChanges $scope.editor.wantTrackChanges = value $http.post "/project/#{$scope.project_id}/track_changes", {_csrf: window.csrfToken, on: value} event_tracking.sendMB "rp-trackchanges-toggle", { value }