github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #18789 from overleaf/ii-invite-token-lookup-by-hmac-token

Browse source 
[web] Lookup project invitations by HMAC token

GitOrigin-RevId: b631445e18f83ddb5e7708388a57a0fac0f73bd2
This commit is contained in:
ilkin-overleaf 2024-06-20 15:18:11 +03:00 committed by Copybot
parent 2a6b84596e
commit 34311ce0dc
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/app/src/Features/Collaborators/CollaboratorsInviteHandler.js
View file

@ -149,7 +149,7 @@ const CollaboratorsInviteHandler = {
logger.debug({ projectId }, 'fetching invite by token') logger.debug({ projectId }, 'fetching invite by token')
const invite = await ProjectInvite.findOne({ const invite = await ProjectInvite.findOne({
projectId, projectId,
token: tokenString, tokenHmac: CollaboratorsInviteHelper.hashInviteToken(tokenString),
}).exec() }).exec()
if (invite == null) { if (invite == null) {

6
services/web/test/unit/src/Collaborators/CollaboratorsInviteHandlerTests.js
View file

@ -41,8 +41,9 @@ describe('CollaboratorsInviteHandler', function () {
this.UserGetter = { promises: { getUser: sinon.stub() } } this.UserGetter = { promises: { getUser: sinon.stub() } }
this.ProjectGetter = { promises: {} } this.ProjectGetter = { promises: {} }
this.NotificationsBuilder = { promises: {} } this.NotificationsBuilder = { promises: {} }
this.tokenHmac = 'jkhajkefhaekjfhkfg'
this.CollaboratorsInviteHelper = { this.CollaboratorsInviteHelper = {
hashInviteToken: sinon.stub().returns('abcd'), hashInviteToken: sinon.stub().returns(this.tokenHmac),
} }
this.CollaboratorsInviteHandler = SandboxedModule.require(MODULE_PATH, { this.CollaboratorsInviteHandler = SandboxedModule.require(MODULE_PATH, {
@ -73,7 +74,6 @@ describe('CollaboratorsInviteHandler', function () {
} }
this.inviteId = new ObjectId() this.inviteId = new ObjectId()
this.token = 'hnhteaosuhtaeosuahs' this.token = 'hnhteaosuhtaeosuahs'
this.tokenHmac = 'jkhajkefhaekjfhkfg'
this.privileges = 'readAndWrite' this.privileges = 'readAndWrite'
this.fakeInvite = { this.fakeInvite = {
_id: this.inviteId, _id: this.inviteId,
@ -458,7 +458,7 @@ describe('CollaboratorsInviteHandler', function () {
await this.call() await this.call()
this.ProjectInvite.findOne.callCount.should.equal(1) this.ProjectInvite.findOne.callCount.should.equal(1)
this.ProjectInvite.findOne this.ProjectInvite.findOne
.calledWith({ projectId: this.projectId, token: this.token }) .calledWith({ projectId: this.projectId, tokenHmac: this.tokenHmac })
.should.equal(true) .should.equal(true)
}) })
}) })