From 338eaf9a075d63b3325dda2ca9c4dbc880ccb713 Mon Sep 17 00:00:00 2001
From: Jakob Ackermann <jakob.ackermann@overleaf.com>
Date: Thu, 30 Jun 2022 10:39:11 +0100
Subject: [PATCH] Merge pull request #8591 from
 overleaf/jpa-fix-pdf-caching-metrics

[clsi] fix options forwarding to pdf caching summary metrics

GitOrigin-RevId: 255fca6a1e980f08deec97ede5bc1d27e83dbda1
---
 services/clsi/app/js/ContentCacheMetrics.js | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/services/clsi/app/js/ContentCacheMetrics.js b/services/clsi/app/js/ContentCacheMetrics.js
index 370c7c9431..e22e93ea9c 100644
--- a/services/clsi/app/js/ContentCacheMetrics.js
+++ b/services/clsi/app/js/ContentCacheMetrics.js
@@ -29,7 +29,7 @@ function emitPdfStats(stats, timings, request) {
     emitPdfCachingStats(stats, timings, request)
   } else {
     // How much bandwidth will the pdf incur when downloaded in full?
-    Metrics.summary('pdf-bandwidth', stats['pdf-size'], 1, request.metricsOpts)
+    Metrics.summary('pdf-bandwidth', stats['pdf-size'], request.metricsOpts)
   }
 }
 
@@ -63,7 +63,6 @@ function emitPdfCachingStats(stats, timings, request) {
   Metrics.summary(
     'overhead-compute-pdf-ranges',
     fraction * 100 - 100,
-    1,
     request.metricsOpts
   )
 
@@ -95,7 +94,6 @@ function emitPdfCachingStats(stats, timings, request) {
     Metrics.summary(
       'new-pdf-ranges-relative-to-total-ranges',
       (stats['pdf-caching-n-new-ranges'] / stats['pdf-caching-n-ranges']) * 100,
-      1,
       request.metricsOpts
     )
   }
@@ -104,7 +102,6 @@ function emitPdfCachingStats(stats, timings, request) {
   Metrics.summary(
     'cacheable-ranges-to-pdf-size',
     (stats['pdf-caching-total-ranges-size'] / stats['pdf-size']) * 100,
-    1,
     request.metricsOpts
   )
 
@@ -120,7 +117,6 @@ function emitPdfCachingStats(stats, timings, request) {
   Metrics.summary(
     'pdf-bandwidth-savings',
     100 - (sizeWhenDownloadedInFull / stats['pdf-size']) * 100,
-    1,
     request.metricsOpts
   )
 
@@ -128,7 +124,6 @@ function emitPdfCachingStats(stats, timings, request) {
   Metrics.summary(
     'pdf-bandwidth',
     sizeWhenDownloadedInFull,
-    1,
     request.metricsOpts
   )
 
@@ -137,7 +132,6 @@ function emitPdfCachingStats(stats, timings, request) {
   Metrics.summary(
     'pdf-ranges-disk-size',
     stats['pdf-caching-new-ranges-size'] - stats['pdf-caching-reclaimed-space'],
-    1,
     request.metricsOpts
   )
 }