github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-30 07:05:19 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2514 from overleaf/revert-2504-bg-initialise-history-on-open

Browse source 
Revert "create v2 history for old projects when opened"

GitOrigin-RevId: 81c613e82872a0938c5621e3108b2457935468f1
This commit is contained in:
Brian Gough 2020-01-13 13:54:17 +00:00 committed by Copybot
parent c7824ced7b
commit 31bc0c640b
2 changed files with 0 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
services/web/app/src/Features/Project/ProjectController.js
View file

@ -6,7 +6,6 @@ const logger = require('logger-sharelatex')
const ProjectDeleter = require('./ProjectDeleter') const ProjectDeleter = require('./ProjectDeleter')
const ProjectDuplicator = require('./ProjectDuplicator') const ProjectDuplicator = require('./ProjectDuplicator')
const ProjectCreationHandler = require('./ProjectCreationHandler') const ProjectCreationHandler = require('./ProjectCreationHandler')
const ProjectHistoryHandler = require('./ProjectHistoryHandler')
const EditorController = require('../Editor/EditorController') const EditorController = require('../Editor/EditorController')
const ProjectHelper = require('./ProjectHelper') const ProjectHelper = require('./ProjectHelper')
const metrics = require('metrics-sharelatex') const metrics = require('metrics-sharelatex')
@ -700,9 +699,6 @@ const ProjectController = {
activate(cb) { activate(cb) {
InactiveProjectManager.reactivateProjectIfRequired(projectId, cb) InactiveProjectManager.reactivateProjectIfRequired(projectId, cb)
}, },
ensureHistoryExists(cb) {
ProjectHistoryHandler.ensureHistoryExistsForProject(projectId, cb)
},
markAsOpened(cb) { markAsOpened(cb) {
// don't need to wait for this to complete // don't need to wait for this to complete
ProjectUpdateHandler.markAsOpened(projectId, () => {}) ProjectUpdateHandler.markAsOpened(projectId, () => {})

14
services/web/test/unit/src/Project/ProjectControllerTests.js
View file

@ -56,9 +56,6 @@ describe('ProjectController', function() {
.stub() .stub()
.callsArgWith(2, null, { _id: this.project_id }) .callsArgWith(2, null, { _id: this.project_id })
} }
this.ProjectHistoryHandler = {
ensureHistoryExistsForProject: sinon.stub().callsArg(1)
}
this.SubscriptionLocator = { getUsersSubscription: sinon.stub() } this.SubscriptionLocator = { getUsersSubscription: sinon.stub() }
this.LimitationsManager = { hasPaidSubscription: sinon.stub() } this.LimitationsManager = { hasPaidSubscription: sinon.stub() }
this.TagsHandler = { getAllTags: sinon.stub() } this.TagsHandler = { getAllTags: sinon.stub() }
@ -160,7 +157,6 @@ describe('ProjectController', function() {
'./ProjectDeleter': this.ProjectDeleter, './ProjectDeleter': this.ProjectDeleter,
'./ProjectDuplicator': this.ProjectDuplicator, './ProjectDuplicator': this.ProjectDuplicator,
'./ProjectCreationHandler': this.ProjectCreationHandler, './ProjectCreationHandler': this.ProjectCreationHandler,
'./ProjectHistoryHandler': this.ProjectHistoryHandler,
'../Editor/EditorController': this.EditorController, '../Editor/EditorController': this.EditorController,
'../User/UserController': this.UserController, '../User/UserController': this.UserController,
'./ProjectHelper': this.ProjectHelper, './ProjectHelper': this.ProjectHelper,
@ -1137,16 +1133,6 @@ describe('ProjectController', function() {
this.ProjectController.loadEditor(this.req, this.res) this.ProjectController.loadEditor(this.req, this.res)
}) })
it('should ensureHistoryExistsForProject', function(done) {
this.res.render = (pageName, opts) => {
this.ProjectHistoryHandler.ensureHistoryExistsForProject
.calledWith(this.project_id)
.should.equal(true)
done()
}
this.ProjectController.loadEditor(this.req, this.res)
})
it('should mark project as opened', function(done) { it('should mark project as opened', function(done) {
this.res.render = (pageName, opts) => { this.res.render = (pageName, opts) => {
this.ProjectUpdateHandler.markAsOpened this.ProjectUpdateHandler.markAsOpened