From 315414de1b4f88aaf27471e433e46be8c2d8f09e Mon Sep 17 00:00:00 2001 From: Jakob Ackermann Date: Thu, 28 Jul 2022 15:39:17 +0100 Subject: [PATCH] Merge pull request #9011 from overleaf/jpa-better-render-error-message [web] provide helpful error message when pdf rendering fails GitOrigin-RevId: abbe6f362fa362fadee197527463ee675760e581 --- .../pdf-preview/components/pdf-preview-error.js | 8 ++++++++ .../components/pdf-preview/pdf-preview.spec.tsx | 10 ++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/services/web/frontend/js/features/pdf-preview/components/pdf-preview-error.js b/services/web/frontend/js/features/pdf-preview/components/pdf-preview-error.js index 3ddd04b789..2b4868acb1 100644 --- a/services/web/frontend/js/features/pdf-preview/components/pdf-preview-error.js +++ b/services/web/frontend/js/features/pdf-preview/components/pdf-preview-error.js @@ -16,6 +16,14 @@ function PdfPreviewError({ error }) { return ( {t('something_went_wrong_rendering_pdf')} +   + , + ]} + /> ) diff --git a/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx b/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx index 8c670ef331..2dc517c3ae 100644 --- a/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx +++ b/services/web/test/frontend/components/pdf-preview/pdf-preview.spec.tsx @@ -557,7 +557,10 @@ describe('', function () { cy.wait('@compile-pdf-error') - cy.findByText('Something went wrong while rendering this PDF.') + cy.contains('Something went wrong while rendering this PDF.') + cy.contains( + 'Please try recompiling the project from scratch, and if that doesn’t help, follow our troubleshooting guide.' + ) cy.findByLabelText('Page 1').should('not.exist') }) @@ -578,7 +581,10 @@ describe('', function () { cy.wait('@compile-pdf-corrupt') - cy.findByText('Something went wrong while rendering this PDF.') + cy.contains('Something went wrong while rendering this PDF.') + cy.contains( + 'Please try recompiling the project from scratch, and if that doesn’t help, follow our troubleshooting guide.' + ) cy.findByLabelText('Page 1').should('not.exist') }) })