From 30a2997b43b44f251f6847a7e3bcc311f66ad232 Mon Sep 17 00:00:00 2001 From: Jessica Lawshe Date: Tue, 12 May 2020 09:23:53 -0500 Subject: [PATCH] Merge pull request #2789 from overleaf/as-fix-no-undef Enable no-undef linting rule for all frontend files and fix errors GitOrigin-RevId: bf9c789a381af982bdece55a2f518a2b610c9202 --- services/web/.eslintrc | 4 +- .../frontend/js/analytics/AbTestingManager.js | 1 - services/web/frontend/js/base.js | 5 +- .../js/components/inputSuggestions.js | 1 - .../web/frontend/js/directives/asyncForm.js | 1 - .../frontend/js/directives/complexPassword.js | 3 +- .../web/frontend/js/directives/creditCards.js | 127 +++++++++--------- services/web/frontend/js/directives/equals.js | 1 - .../frontend/js/directives/eventTracking.js | 1 - .../js/directives/expandableTextArea.js | 1 - .../web/frontend/js/directives/fineUpload.js | 1 - services/web/frontend/js/directives/focus.js | 1 - .../web/frontend/js/directives/maxHeight.js | 1 - .../web/frontend/js/directives/onEnter.js | 1 - .../web/frontend/js/directives/rightClick.js | 1 - services/web/frontend/js/directives/scroll.js | 1 - .../web/frontend/js/directives/selectAll.js | 1 - .../frontend/js/directives/stopPropagation.js | 1 - .../frontend/js/directives/videoPlayState.js | 1 - .../web/frontend/js/filters/formatDate.js | 1 - .../web/frontend/js/filters/wrapLongWords.js | 1 - services/web/frontend/js/ide.js | 1 - .../frontend/js/ide/SafariScrollPatcher.js | 1 - .../js/ide/binary-files/BinaryFilesManager.js | 1 - .../chat/controllers/ChatButtonController.js | 1 - .../js/ide/chat/controllers/ChatController.js | 1 - .../chat/controllers/ChatMessageController.js | 1 - services/web/frontend/js/ide/chat/index.js | 1 - .../js/ide/chat/services/chatMessages.js | 3 +- .../controllers/CloneProjectController.js | 1 - .../CloneProjectModalController.js | 1 - services/web/frontend/js/ide/clone/index.js | 1 - .../ide/cobranding/CobrandingDataService.js | 1 - .../frontend/js/ide/colors/ColorManager.js | 24 +++- .../frontend/js/ide/directives/SafePath.js | 1 - .../web/frontend/js/ide/directives/layout.js | 1 - .../frontend/js/ide/directives/validFile.js | 1 - .../web/frontend/js/ide/editor/Document.js | 1 - .../frontend/js/ide/editor/EditorManager.js | 1 - .../js/ide/editor/EditorShareJsCodec.js | 1 - .../web/frontend/js/ide/editor/ShareJsDoc.js | 3 +- .../js/ide/editor/components/spellMenu.js | 1 - .../SavingNotificationController.js | 1 - .../aceEditor/auto-complete/CommandManager.js | 1 - .../auto-complete/EnvironmentManager.js | 1 - .../aceEditor/auto-complete/Helpers.js | 1 - .../aceEditor/auto-complete/PackageManager.js | 1 - .../auto-complete/snippets/Environments.js | 1 - .../snippets/TopHundredSnippets.js | 1 - .../cursor-position/CursorPositionAdapter.js | 1 - .../cursor-position/CursorPositionManager.js | 1 - .../aceEditor/highlights/HighlightsManager.js | 1 - .../aceEditor/metadata/MetadataManager.js | 1 - .../spell-check/HighlightedWordManager.js | 1 - .../js/ide/editor/directives/toggleSwitch.js | 1 - .../js/ide/file-tree/FileTreeManager.js | 1 - .../controllers/FileTreeController.js | 3 +- .../controllers/FileTreeEntityController.js | 1 - .../controllers/FileTreeFolderController.js | 1 - .../FileTreeRootFolderController.js | 1 - .../js/ide/file-tree/directives/draggable.js | 1 - .../js/ide/file-tree/directives/droppable.js | 1 - .../js/ide/file-tree/directives/fileEntity.js | 1 - .../js/ide/file-tree/util/iconTypeFromName.js | 1 - .../js/ide/graphics/services/graphics.js | 1 - .../frontend/js/ide/history/HistoryManager.js | 1 - .../js/ide/history/HistoryV2Manager.js | 5 +- .../history/components/historyEntriesList.js | 1 - .../js/ide/history/components/historyEntry.js | 1 - .../history/components/historyFileEntity.js | 1 - .../ide/history/components/historyFileTree.js | 1 - .../js/ide/history/components/historyLabel.js | 1 - .../history/components/historyLabelsList.js | 1 - .../controllers/HistoryDiffController.js | 1 - .../controllers/HistoryListController.js | 1 - .../HistoryV2AddLabelModalController.js | 1 - .../HistoryV2DeleteLabelModalController.js | 1 - .../HistoryV2FileTreeController.js | 1 - .../controllers/HistoryV2ListController.js | 1 - .../controllers/HistoryV2ToolbarController.js | 1 - .../ide/history/directives/infiniteScroll.js | 1 - .../js/ide/history/util/HistoryViewModes.js | 1 - .../js/ide/history/util/displayNameForUser.js | 1 - .../js/ide/hotkeys/BackspaceHighjack.js | 1 - .../hotkeys/controllers/HotkeysController.js | 1 - services/web/frontend/js/ide/hotkeys/index.js | 1 - .../human-readable-logs/HumanReadableLogs.js | 1 - .../HumanReadableLogsRules.js | 1 - .../js/ide/metadata/MetadataManager.js | 1 - .../js/ide/metadata/services/metadata.js | 1 - .../js/ide/online-users/OnlineUsersManager.js | 1 - .../controllers/OnlineUsersController.js | 1 - .../web/frontend/js/ide/pdf/PdfManager.js | 1 - .../controllers/PdfViewToggleController.js | 1 - .../js/ide/pdfng/directives/pdfHighlights.js | 1 - .../frontend/js/ide/pdfng/directives/pdfJs.js | 1 - .../js/ide/pdfng/directives/pdfPage.js | 1 - .../js/ide/pdfng/directives/pdfRenderer.js | 1 - .../js/ide/pdfng/directives/pdfSpinner.js | 1 - .../js/ide/pdfng/directives/pdfTextLayer.js | 1 - .../js/ide/pdfng/directives/pdfViewer.js | 1 - .../js/ide/permissions/PermissionsManager.js | 1 - .../js/ide/preamble/services/preamble.js | 1 - .../js/ide/references/ReferencesManager.js | 1 - .../js/ide/review-panel/RangesTracker.js | 1 - .../js/ide/review-panel/ReviewPanelManager.js | 1 - .../controllers/BulkActionsModalController.js | 1 - .../controllers/ReviewPanelController.js | 1 - .../TrackChangesUpgradeModalController.js | 1 - .../directives/aggregateChangeEntry.js | 1 - .../directives/bulkActionsEntry.js | 1 - .../review-panel/directives/changeEntry.js | 1 - .../review-panel/directives/commentEntry.js | 1 - .../directives/resolvedCommentEntry.js | 1 - .../directives/resolvedCommentsDropdown.js | 1 - .../directives/reviewPanelCollapseHeight.js | 1 - .../directives/reviewPanelSorted.js | 1 - .../directives/reviewPanelToggle.js | 1 - .../js/ide/review-panel/filters/notEmpty.js | 1 - .../js/ide/review-panel/filters/numKeys.js | 1 - .../filters/orderOverviewEntries.js | 1 - services/web/frontend/js/ide/services/ide.js | 1 - .../controllers/ProjectNameController.js | 1 - .../controllers/SettingsController.js | 1 - .../web/frontend/js/ide/settings/index.js | 1 - .../js/ide/settings/services/settings.js | 1 - .../controllers/WordCountController.js | 1 - .../controllers/WordCountModalController.js | 1 - .../web/frontend/js/ide/wordcount/index.js | 1 - services/web/frontend/js/main.js | 1 - .../components/affiliationForm.js | 1 - .../controllers/UserAffiliationsController.js | 1 - .../web/frontend/js/main/annual-upgrade.js | 1 - services/web/frontend/js/main/bonus.js | 1 - .../web/frontend/js/main/clear-sessions.js | 1 - services/web/frontend/js/main/contact-us.js | 8 +- services/web/frontend/js/main/event.js | 12 -- services/web/frontend/js/main/keys.js | 1 - services/web/frontend/js/main/learn.js | 1 - .../frontend/js/main/project-list/index.js | 1 - .../js/main/project-list/modal-controllers.js | 1 - .../web/frontend/js/main/register-users.js | 1 - .../web/frontend/js/main/scribtex-popup.js | 1 - .../js/main/subscription-dashboard.js | 6 +- .../subscription/team-invite-controller.js | 3 +- .../web/frontend/js/main/system-messages.js | 1 - services/web/frontend/js/main/translations.js | 1 - .../web/frontend/js/main/user-membership.js | 13 +- .../web/frontend/js/modules/errorCatcher.js | 1 - .../frontend/js/modules/recursionHelper.js | 1 - .../frontend/js/services/algolia-search.js | 1 - .../web/frontend/js/services/queued-http.js | 1 - .../frontend/js/services/validateCaptcha.js | 3 +- services/web/frontend/js/services/wait-for.js | 1 - .../web/frontend/js/utils/EventEmitter.js | 1 - services/web/frontend/js/utils/underscore.js | 1 - 156 files changed, 114 insertions(+), 249 deletions(-) diff --git a/services/web/.eslintrc b/services/web/.eslintrc index ca51d5200a..0c74136c81 100644 --- a/services/web/.eslintrc +++ b/services/web/.eslintrc @@ -103,10 +103,12 @@ "_": true, "ace": true, "ga": true, + "Raven": true, // Backwards compat for Sentry reporting "sl_console": true, "sl_debugging": true, // Injected in layout.pug - "user_id": true + "user_id": true, + "ExposedSettings": true } } ] diff --git a/services/web/frontend/js/analytics/AbTestingManager.js b/services/web/frontend/js/analytics/AbTestingManager.js index a9401a5858..c237d23b3e 100644 --- a/services/web/frontend/js/analytics/AbTestingManager.js +++ b/services/web/frontend/js/analytics/AbTestingManager.js @@ -1,7 +1,6 @@ /* eslint-disable camelcase, max-len, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/base.js b/services/web/frontend/js/base.js index fa44ae3041..d9bb0cb760 100644 --- a/services/web/frontend/js/base.js +++ b/services/web/frontend/js/base.js @@ -1,7 +1,8 @@ +/* global MathJax */ + /* eslint-disable camelcase, max-len, - no-undef, no-useless-escape, */ // TODO: This file was created by bulk-decaffeinate. @@ -17,7 +18,7 @@ // Configure dynamically loaded assets (via webpack) to be downloaded from CDN // See: https://webpack.js.org/guides/public-path/#on-the-fly -__webpack_public_path__ = window.baseAssetPath +__webpack_public_path__ = window.baseAssetPath // eslint-disable-line no-undef define([ './libraries', diff --git a/services/web/frontend/js/components/inputSuggestions.js b/services/web/frontend/js/components/inputSuggestions.js index 0806b4ab00..7e60c7d543 100644 --- a/services/web/frontend/js/components/inputSuggestions.js +++ b/services/web/frontend/js/components/inputSuggestions.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/asyncForm.js b/services/web/frontend/js/directives/asyncForm.js index 6deb81864b..8762f37077 100644 --- a/services/web/frontend/js/directives/asyncForm.js +++ b/services/web/frontend/js/directives/asyncForm.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/directives/complexPassword.js b/services/web/frontend/js/directives/complexPassword.js index a722dfb8f3..6ee699b534 100644 --- a/services/web/frontend/js/directives/complexPassword.js +++ b/services/web/frontend/js/directives/complexPassword.js @@ -1,5 +1,6 @@ +/* global PassField */ + /* eslint-disable - no-undef, max-len */ define(['../base', 'libs/passfield'], function(App) { diff --git a/services/web/frontend/js/directives/creditCards.js b/services/web/frontend/js/directives/creditCards.js index 2eb068c928..7bb8c1d3ef 100644 --- a/services/web/frontend/js/directives/creditCards.js +++ b/services/web/frontend/js/directives/creditCards.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, no-useless-escape, */ // TODO: This file was created by bulk-decaffeinate. @@ -14,70 +13,70 @@ * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md */ define(['../base'], function(App) { + const defaultFormat = /(\d{1,4})/g + const defaultInputFormat = /(?:^|\s)(\d{4})$/ + + const cards = [ + // Credit cards + { + type: 'visa', + patterns: [4], + format: defaultFormat, + length: [13, 16], + cvcLength: [3], + luhn: true + }, + { + type: 'mastercard', + patterns: [51, 52, 53, 54, 55, 22, 23, 24, 25, 26, 27], + format: defaultFormat, + length: [16], + cvcLength: [3], + luhn: true + }, + { + type: 'amex', + patterns: [34, 37], + format: /(\d{1,4})(\d{1,6})?(\d{1,5})?/, + length: [15], + cvcLength: [3, 4], + luhn: true + }, + { + type: 'dinersclub', + patterns: [30, 36, 38, 39], + format: /(\d{1,4})(\d{1,6})?(\d{1,4})?/, + length: [14], + cvcLength: [3], + luhn: true + }, + { + type: 'discover', + patterns: [60, 64, 65, 622], + format: defaultFormat, + length: [16], + cvcLength: [3], + luhn: true + }, + { + type: 'unionpay', + patterns: [62, 88], + format: defaultFormat, + length: [16, 17, 18, 19], + cvcLength: [3], + luhn: false + }, + { + type: 'jcb', + patterns: [35], + format: defaultFormat, + length: [16], + cvcLength: [3], + luhn: true + } + ] + App.factory('ccUtils', function() { - const defaultFormat = /(\d{1,4})/g - const defaultInputFormat = /(?:^|\s)(\d{4})$/ - - const cards = [ - // Credit cards - { - type: 'visa', - patterns: [4], - format: defaultFormat, - length: [13, 16], - cvcLength: [3], - luhn: true - }, - { - type: 'mastercard', - patterns: [51, 52, 53, 54, 55, 22, 23, 24, 25, 26, 27], - format: defaultFormat, - length: [16], - cvcLength: [3], - luhn: true - }, - { - type: 'amex', - patterns: [34, 37], - format: /(\d{1,4})(\d{1,6})?(\d{1,5})?/, - length: [15], - cvcLength: [3, 4], - luhn: true - }, - { - type: 'dinersclub', - patterns: [30, 36, 38, 39], - format: /(\d{1,4})(\d{1,6})?(\d{1,4})?/, - length: [14], - cvcLength: [3], - luhn: true - }, - { - type: 'discover', - patterns: [60, 64, 65, 622], - format: defaultFormat, - length: [16], - cvcLength: [3], - luhn: true - }, - { - type: 'unionpay', - patterns: [62, 88], - format: defaultFormat, - length: [16, 17, 18, 19], - cvcLength: [3], - luhn: false - }, - { - type: 'jcb', - patterns: [35], - format: defaultFormat, - length: [16], - cvcLength: [3], - luhn: true - } - ] - const cardFromNumber = function(num) { num = (num + '').replace(/\D/g, '') for (let card of Array.from(cards)) { diff --git a/services/web/frontend/js/directives/equals.js b/services/web/frontend/js/directives/equals.js index 6ddb63e1e4..3c3c24ba1e 100644 --- a/services/web/frontend/js/directives/equals.js +++ b/services/web/frontend/js/directives/equals.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/eventTracking.js b/services/web/frontend/js/directives/eventTracking.js index ab5d260d19..b8f297dfa6 100644 --- a/services/web/frontend/js/directives/eventTracking.js +++ b/services/web/frontend/js/directives/eventTracking.js @@ -1,7 +1,6 @@ /* eslint-disable camelcase, max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/expandableTextArea.js b/services/web/frontend/js/directives/expandableTextArea.js index 353fd74a54..a9eca3c5d9 100644 --- a/services/web/frontend/js/directives/expandableTextArea.js +++ b/services/web/frontend/js/directives/expandableTextArea.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/fineUpload.js b/services/web/frontend/js/directives/fineUpload.js index c19673a49d..47fb85fab3 100644 --- a/services/web/frontend/js/directives/fineUpload.js +++ b/services/web/frontend/js/directives/fineUpload.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/focus.js b/services/web/frontend/js/directives/focus.js index b0e5570799..7fad1b3f14 100644 --- a/services/web/frontend/js/directives/focus.js +++ b/services/web/frontend/js/directives/focus.js @@ -1,6 +1,5 @@ /* eslint-disable no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/maxHeight.js b/services/web/frontend/js/directives/maxHeight.js index cfc90f1cc9..52237c3c7f 100644 --- a/services/web/frontend/js/directives/maxHeight.js +++ b/services/web/frontend/js/directives/maxHeight.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/onEnter.js b/services/web/frontend/js/directives/onEnter.js index d928b1ee09..91964ca779 100644 --- a/services/web/frontend/js/directives/onEnter.js +++ b/services/web/frontend/js/directives/onEnter.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/rightClick.js b/services/web/frontend/js/directives/rightClick.js index b6f92d7390..57d12ec072 100644 --- a/services/web/frontend/js/directives/rightClick.js +++ b/services/web/frontend/js/directives/rightClick.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/scroll.js b/services/web/frontend/js/directives/scroll.js index 196b15a33e..54602062a2 100644 --- a/services/web/frontend/js/directives/scroll.js +++ b/services/web/frontend/js/directives/scroll.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/selectAll.js b/services/web/frontend/js/directives/selectAll.js index abc3ee3977..c1849d41c5 100644 --- a/services/web/frontend/js/directives/selectAll.js +++ b/services/web/frontend/js/directives/selectAll.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/stopPropagation.js b/services/web/frontend/js/directives/stopPropagation.js index 1b5a1a16f7..038cab58cf 100644 --- a/services/web/frontend/js/directives/stopPropagation.js +++ b/services/web/frontend/js/directives/stopPropagation.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/directives/videoPlayState.js b/services/web/frontend/js/directives/videoPlayState.js index c940c7c813..3aab1f81e7 100644 --- a/services/web/frontend/js/directives/videoPlayState.js +++ b/services/web/frontend/js/directives/videoPlayState.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/filters/formatDate.js b/services/web/frontend/js/filters/formatDate.js index d759831c83..ac3e0efdd1 100644 --- a/services/web/frontend/js/filters/formatDate.js +++ b/services/web/frontend/js/filters/formatDate.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/filters/wrapLongWords.js b/services/web/frontend/js/filters/wrapLongWords.js index 51043c26c5..b65bf2a2a6 100644 --- a/services/web/frontend/js/filters/wrapLongWords.js +++ b/services/web/frontend/js/filters/wrapLongWords.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, no-useless-escape, */ diff --git a/services/web/frontend/js/ide.js b/services/web/frontend/js/ide.js index 75315517dd..a00cceceb5 100644 --- a/services/web/frontend/js/ide.js +++ b/services/web/frontend/js/ide.js @@ -3,7 +3,6 @@ max-len, no-cond-assign, no-return-assign, - no-undef, no-unused-vars, no-useless-escape, */ diff --git a/services/web/frontend/js/ide/SafariScrollPatcher.js b/services/web/frontend/js/ide/SafariScrollPatcher.js index 47d6f0edc7..713768c9dd 100644 --- a/services/web/frontend/js/ide/SafariScrollPatcher.js +++ b/services/web/frontend/js/ide/SafariScrollPatcher.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/binary-files/BinaryFilesManager.js b/services/web/frontend/js/ide/binary-files/BinaryFilesManager.js index bfc72e95eb..0d0dad62dd 100644 --- a/services/web/frontend/js/ide/binary-files/BinaryFilesManager.js +++ b/services/web/frontend/js/ide/binary-files/BinaryFilesManager.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/chat/controllers/ChatButtonController.js b/services/web/frontend/js/ide/chat/controllers/ChatButtonController.js index cdec1b9eee..395c714ce3 100644 --- a/services/web/frontend/js/ide/chat/controllers/ChatButtonController.js +++ b/services/web/frontend/js/ide/chat/controllers/ChatButtonController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/chat/controllers/ChatController.js b/services/web/frontend/js/ide/chat/controllers/ChatController.js index 29c79acf40..370d161536 100644 --- a/services/web/frontend/js/ide/chat/controllers/ChatController.js +++ b/services/web/frontend/js/ide/chat/controllers/ChatController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/chat/controllers/ChatMessageController.js b/services/web/frontend/js/ide/chat/controllers/ChatMessageController.js index 662304204d..314c0c0f39 100644 --- a/services/web/frontend/js/ide/chat/controllers/ChatMessageController.js +++ b/services/web/frontend/js/ide/chat/controllers/ChatMessageController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/chat/index.js b/services/web/frontend/js/ide/chat/index.js index 16452716f0..5e198cec1c 100644 --- a/services/web/frontend/js/ide/chat/index.js +++ b/services/web/frontend/js/ide/chat/index.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/chat/services/chatMessages.js b/services/web/frontend/js/ide/chat/services/chatMessages.js index 583f9eccb2..58d2fbf100 100644 --- a/services/web/frontend/js/ide/chat/services/chatMessages.js +++ b/services/web/frontend/js/ide/chat/services/chatMessages.js @@ -1,7 +1,8 @@ +/* global Raven */ + /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/clone/controllers/CloneProjectController.js b/services/web/frontend/js/ide/clone/controllers/CloneProjectController.js index 4b3699a2ee..98512b14b7 100644 --- a/services/web/frontend/js/ide/clone/controllers/CloneProjectController.js +++ b/services/web/frontend/js/ide/clone/controllers/CloneProjectController.js @@ -1,6 +1,5 @@ /* eslint-disable no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/clone/controllers/CloneProjectModalController.js b/services/web/frontend/js/ide/clone/controllers/CloneProjectModalController.js index a7dea9e04d..dcac45cab1 100644 --- a/services/web/frontend/js/ide/clone/controllers/CloneProjectModalController.js +++ b/services/web/frontend/js/ide/clone/controllers/CloneProjectModalController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/clone/index.js b/services/web/frontend/js/ide/clone/index.js index ea5a356b90..43c7bdbe7e 100644 --- a/services/web/frontend/js/ide/clone/index.js +++ b/services/web/frontend/js/ide/clone/index.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/cobranding/CobrandingDataService.js b/services/web/frontend/js/ide/cobranding/CobrandingDataService.js index 38943277d8..fd461d40dd 100644 --- a/services/web/frontend/js/ide/cobranding/CobrandingDataService.js +++ b/services/web/frontend/js/ide/cobranding/CobrandingDataService.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/colors/ColorManager.js b/services/web/frontend/js/ide/colors/ColorManager.js index 1eaea6fd70..11f1bd515a 100644 --- a/services/web/frontend/js/ide/colors/ColorManager.js +++ b/services/web/frontend/js/ide/colors/ColorManager.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. @@ -48,8 +47,10 @@ define(['crypto-js/md5'], function(CryptoJS) { return r + g + b < 3 * 128 }, - OWN_HUE: 200, // We will always appear as this color to ourselves ANONYMOUS_HUE: 100, + OWN_HUE: 200, // We will always appear as this color to ourselves + OWN_HUE_BLOCKED_SIZE: 20, // no other user should havea HUE in this range + TOTAL_HUES: 360, // actually 361, but 360 for legacy reasons getHueForUserId(user_id) { if (user_id == null || user_id === 'anonymous-user') { return this.ANONYMOUS_HUE @@ -59,11 +60,18 @@ define(['crypto-js/md5'], function(CryptoJS) { return this.OWN_HUE } - hue = this.getHueForId(user_id) - // Avoid 20 degrees either side of the personal hue - if (hue > this.OWNER_HUE - 20) { - hue = hue + 40 + let hue = this.getHueForId(user_id) + + // if `hue` is within `OWN_HUE_BLOCKED_SIZE` degrees of the personal hue + // (`OWN_HUE`), shift `hue` to the end of available hues by adding + if ( + hue > this.OWN_HUE - this.OWN_HUE_BLOCKED_SIZE && + hue < this.OWN_HUE + this.OWN_HUE_BLOCKED_SIZE + ) { + hue = hue - this.OWN_HUE // `hue` now at 0 +/- `OWN_HUE_BLOCKED_SIZE` + hue = hue + this.TOTAL_HUES - this.OWN_HUE_BLOCKED_SIZE } + return hue }, @@ -73,7 +81,9 @@ define(['crypto-js/md5'], function(CryptoJS) { getHueForId(id) { const hash = CryptoJS(id) - let hue = parseInt(hash.toString().slice(0, 8), 16) % 320 + let hue = + parseInt(hash.toString().slice(0, 8), 16) % + (this.TOTAL_HUES - this.OWN_HUE_BLOCKED_SIZE * 2) return hue } }) diff --git a/services/web/frontend/js/ide/directives/SafePath.js b/services/web/frontend/js/ide/directives/SafePath.js index e9f1a16e6f..8eb1d7bb35 100644 --- a/services/web/frontend/js/ide/directives/SafePath.js +++ b/services/web/frontend/js/ide/directives/SafePath.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/directives/layout.js b/services/web/frontend/js/ide/directives/layout.js index f30f9cf763..1aad49d930 100644 --- a/services/web/frontend/js/ide/directives/layout.js +++ b/services/web/frontend/js/ide/directives/layout.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-useless-escape, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/directives/validFile.js b/services/web/frontend/js/ide/directives/validFile.js index b876086831..0b6f4ec203 100644 --- a/services/web/frontend/js/ide/directives/validFile.js +++ b/services/web/frontend/js/ide/directives/validFile.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/editor/Document.js b/services/web/frontend/js/ide/editor/Document.js index ac39fd4b2e..75acb4f5fe 100644 --- a/services/web/frontend/js/ide/editor/Document.js +++ b/services/web/frontend/js/ide/editor/Document.js @@ -2,7 +2,6 @@ camelcase, handle-callback-err, max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/editor/EditorManager.js b/services/web/frontend/js/ide/editor/EditorManager.js index c9047c3876..64cd8c48d4 100644 --- a/services/web/frontend/js/ide/editor/EditorManager.js +++ b/services/web/frontend/js/ide/editor/EditorManager.js @@ -3,7 +3,6 @@ handle-callback-err, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/editor/EditorShareJsCodec.js b/services/web/frontend/js/ide/editor/EditorShareJsCodec.js index 233542ea81..40c1f8077b 100644 --- a/services/web/frontend/js/ide/editor/EditorShareJsCodec.js +++ b/services/web/frontend/js/ide/editor/EditorShareJsCodec.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/editor/ShareJsDoc.js b/services/web/frontend/js/ide/editor/ShareJsDoc.js index 2bda12c77c..7036cbcf74 100644 --- a/services/web/frontend/js/ide/editor/ShareJsDoc.js +++ b/services/web/frontend/js/ide/editor/ShareJsDoc.js @@ -1,7 +1,6 @@ /* eslint-disable camelcase, max-len, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. @@ -157,7 +156,7 @@ define(['../../utils/EventEmitter', 'libs/sharejs'], function( _processQueue() { if (this.queuedMessages.length > 0) { - nextAvailableVersion = this.queuedMessages[0].v + const nextAvailableVersion = this.queuedMessages[0].v if (nextAvailableVersion > this._doc.version) { // there are updates we still can't apply yet } else { diff --git a/services/web/frontend/js/ide/editor/components/spellMenu.js b/services/web/frontend/js/ide/editor/components/spellMenu.js index 12ae482a56..49708f72d7 100644 --- a/services/web/frontend/js/ide/editor/components/spellMenu.js +++ b/services/web/frontend/js/ide/editor/components/spellMenu.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/editor/controllers/SavingNotificationController.js b/services/web/frontend/js/ide/editor/controllers/SavingNotificationController.js index b08a67c33f..0055131260 100644 --- a/services/web/frontend/js/ide/editor/controllers/SavingNotificationController.js +++ b/services/web/frontend/js/ide/editor/controllers/SavingNotificationController.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/CommandManager.js b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/CommandManager.js index 731fda4a02..6419df6197 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/CommandManager.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/CommandManager.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/EnvironmentManager.js b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/EnvironmentManager.js index 230b871efe..7d1f8524d8 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/EnvironmentManager.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/EnvironmentManager.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/Helpers.js b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/Helpers.js index 7caaae9c25..cfc75f7a1f 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/Helpers.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/Helpers.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-cond-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/PackageManager.js b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/PackageManager.js index ad70606ada..9e9b12740f 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/PackageManager.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/PackageManager.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/Environments.js b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/Environments.js index ddfac70237..03787ea008 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/Environments.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/Environments.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/TopHundredSnippets.js b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/TopHundredSnippets.js index 158efe0e02..7677fb3157 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/TopHundredSnippets.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor/auto-complete/snippets/TopHundredSnippets.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor/cursor-position/CursorPositionAdapter.js b/services/web/frontend/js/ide/editor/directives/aceEditor/cursor-position/CursorPositionAdapter.js index d862f5dab3..933695edef 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor/cursor-position/CursorPositionAdapter.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor/cursor-position/CursorPositionAdapter.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor/cursor-position/CursorPositionManager.js b/services/web/frontend/js/ide/editor/directives/aceEditor/cursor-position/CursorPositionManager.js index d6eb391483..3201571bd6 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor/cursor-position/CursorPositionManager.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor/cursor-position/CursorPositionManager.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor/highlights/HighlightsManager.js b/services/web/frontend/js/ide/editor/directives/aceEditor/highlights/HighlightsManager.js index a952fd944f..36c8303c53 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor/highlights/HighlightsManager.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor/highlights/HighlightsManager.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor/metadata/MetadataManager.js b/services/web/frontend/js/ide/editor/directives/aceEditor/metadata/MetadataManager.js index 83ef98ee46..76b9abd641 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor/metadata/MetadataManager.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor/metadata/MetadataManager.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-cond-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/editor/directives/aceEditor/spell-check/HighlightedWordManager.js b/services/web/frontend/js/ide/editor/directives/aceEditor/spell-check/HighlightedWordManager.js index eed45e7e4d..99a0b21e89 100644 --- a/services/web/frontend/js/ide/editor/directives/aceEditor/spell-check/HighlightedWordManager.js +++ b/services/web/frontend/js/ide/editor/directives/aceEditor/spell-check/HighlightedWordManager.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/editor/directives/toggleSwitch.js b/services/web/frontend/js/ide/editor/directives/toggleSwitch.js index 093ad21d1b..12e0c441a6 100644 --- a/services/web/frontend/js/ide/editor/directives/toggleSwitch.js +++ b/services/web/frontend/js/ide/editor/directives/toggleSwitch.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/file-tree/FileTreeManager.js b/services/web/frontend/js/ide/file-tree/FileTreeManager.js index 11c711b209..cac170b36b 100644 --- a/services/web/frontend/js/ide/file-tree/FileTreeManager.js +++ b/services/web/frontend/js/ide/file-tree/FileTreeManager.js @@ -4,7 +4,6 @@ max-len, no-dupe-class-members, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/file-tree/controllers/FileTreeController.js b/services/web/frontend/js/ide/file-tree/controllers/FileTreeController.js index 4ca0a577a3..a2d70521bc 100644 --- a/services/web/frontend/js/ide/file-tree/controllers/FileTreeController.js +++ b/services/web/frontend/js/ide/file-tree/controllers/FileTreeController.js @@ -3,7 +3,6 @@ handle-callback-err, max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. @@ -182,7 +181,7 @@ define(['../../../base'], function(App) { } }) return $scope.$on('done', (e, opts = {}) => { - isBibFile = opts.name && /^.*\.bib$/.test(opts.name) + const isBibFile = opts.name && /^.*\.bib$/.test(opts.name) if (opts.shouldReindexReferences || isBibFile) { ide.$scope.$emit('references:should-reindex', {}) } diff --git a/services/web/frontend/js/ide/file-tree/controllers/FileTreeEntityController.js b/services/web/frontend/js/ide/file-tree/controllers/FileTreeEntityController.js index 7f6007c64c..029e4b8640 100644 --- a/services/web/frontend/js/ide/file-tree/controllers/FileTreeEntityController.js +++ b/services/web/frontend/js/ide/file-tree/controllers/FileTreeEntityController.js @@ -2,7 +2,6 @@ chai-friendly/no-unused-expressions, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/file-tree/controllers/FileTreeFolderController.js b/services/web/frontend/js/ide/file-tree/controllers/FileTreeFolderController.js index fd7696862a..9240be8c81 100644 --- a/services/web/frontend/js/ide/file-tree/controllers/FileTreeFolderController.js +++ b/services/web/frontend/js/ide/file-tree/controllers/FileTreeFolderController.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/file-tree/controllers/FileTreeRootFolderController.js b/services/web/frontend/js/ide/file-tree/controllers/FileTreeRootFolderController.js index 080c527002..9dad2d7814 100644 --- a/services/web/frontend/js/ide/file-tree/controllers/FileTreeRootFolderController.js +++ b/services/web/frontend/js/ide/file-tree/controllers/FileTreeRootFolderController.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/file-tree/directives/draggable.js b/services/web/frontend/js/ide/file-tree/directives/draggable.js index dda3e6bcac..728004c8b6 100644 --- a/services/web/frontend/js/ide/file-tree/directives/draggable.js +++ b/services/web/frontend/js/ide/file-tree/directives/draggable.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/file-tree/directives/droppable.js b/services/web/frontend/js/ide/file-tree/directives/droppable.js index df3848b2b0..f393123187 100644 --- a/services/web/frontend/js/ide/file-tree/directives/droppable.js +++ b/services/web/frontend/js/ide/file-tree/directives/droppable.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/file-tree/directives/fileEntity.js b/services/web/frontend/js/ide/file-tree/directives/fileEntity.js index 963676dd9d..d8d7b86621 100644 --- a/services/web/frontend/js/ide/file-tree/directives/fileEntity.js +++ b/services/web/frontend/js/ide/file-tree/directives/fileEntity.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/file-tree/util/iconTypeFromName.js b/services/web/frontend/js/ide/file-tree/util/iconTypeFromName.js index c68e2a43f6..f7ca132a9f 100644 --- a/services/web/frontend/js/ide/file-tree/util/iconTypeFromName.js +++ b/services/web/frontend/js/ide/file-tree/util/iconTypeFromName.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/graphics/services/graphics.js b/services/web/frontend/js/ide/graphics/services/graphics.js index e0da0c91dc..dd78850aa7 100644 --- a/services/web/frontend/js/ide/graphics/services/graphics.js +++ b/services/web/frontend/js/ide/graphics/services/graphics.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/HistoryManager.js b/services/web/frontend/js/ide/history/HistoryManager.js index bca43ef445..c7c1d01976 100644 --- a/services/web/frontend/js/ide/history/HistoryManager.js +++ b/services/web/frontend/js/ide/history/HistoryManager.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/history/HistoryV2Manager.js b/services/web/frontend/js/ide/history/HistoryV2Manager.js index 9ee7c4392d..9cb963994a 100644 --- a/services/web/frontend/js/ide/history/HistoryV2Manager.js +++ b/services/web/frontend/js/ide/history/HistoryV2Manager.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. @@ -401,13 +400,13 @@ define([ ) filesWithOps = [] if (currentUpdate != null) { - for (pathname of currentUpdate.pathnames) { + for (let pathname of currentUpdate.pathnames) { filesWithOps.push({ pathname: pathname, operation: 'edited' }) } - for (op of currentUpdate.project_ops) { + for (let op of currentUpdate.project_ops) { let fileWithOp if (op.add != null) { fileWithOp = { diff --git a/services/web/frontend/js/ide/history/components/historyEntriesList.js b/services/web/frontend/js/ide/history/components/historyEntriesList.js index a90495a3e1..62442f9c36 100644 --- a/services/web/frontend/js/ide/history/components/historyEntriesList.js +++ b/services/web/frontend/js/ide/history/components/historyEntriesList.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/components/historyEntry.js b/services/web/frontend/js/ide/history/components/historyEntry.js index e04c2022d0..92c7501ed4 100644 --- a/services/web/frontend/js/ide/history/components/historyEntry.js +++ b/services/web/frontend/js/ide/history/components/historyEntry.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/components/historyFileEntity.js b/services/web/frontend/js/ide/history/components/historyFileEntity.js index f41e2613c8..13d45809f7 100644 --- a/services/web/frontend/js/ide/history/components/historyFileEntity.js +++ b/services/web/frontend/js/ide/history/components/historyFileEntity.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/components/historyFileTree.js b/services/web/frontend/js/ide/history/components/historyFileTree.js index 39200b51f2..7df9b0448e 100644 --- a/services/web/frontend/js/ide/history/components/historyFileTree.js +++ b/services/web/frontend/js/ide/history/components/historyFileTree.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/components/historyLabel.js b/services/web/frontend/js/ide/history/components/historyLabel.js index 835cce59e3..a8b70fc503 100644 --- a/services/web/frontend/js/ide/history/components/historyLabel.js +++ b/services/web/frontend/js/ide/history/components/historyLabel.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/components/historyLabelsList.js b/services/web/frontend/js/ide/history/components/historyLabelsList.js index 5fe527ad12..ac88fe0b7f 100644 --- a/services/web/frontend/js/ide/history/components/historyLabelsList.js +++ b/services/web/frontend/js/ide/history/components/historyLabelsList.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/controllers/HistoryDiffController.js b/services/web/frontend/js/ide/history/controllers/HistoryDiffController.js index d7b28115bf..8659d6df72 100644 --- a/services/web/frontend/js/ide/history/controllers/HistoryDiffController.js +++ b/services/web/frontend/js/ide/history/controllers/HistoryDiffController.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/controllers/HistoryListController.js b/services/web/frontend/js/ide/history/controllers/HistoryListController.js index e82318629d..f3058046bf 100644 --- a/services/web/frontend/js/ide/history/controllers/HistoryListController.js +++ b/services/web/frontend/js/ide/history/controllers/HistoryListController.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/controllers/HistoryV2AddLabelModalController.js b/services/web/frontend/js/ide/history/controllers/HistoryV2AddLabelModalController.js index eaeee18dd5..5966b7be29 100644 --- a/services/web/frontend/js/ide/history/controllers/HistoryV2AddLabelModalController.js +++ b/services/web/frontend/js/ide/history/controllers/HistoryV2AddLabelModalController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/controllers/HistoryV2DeleteLabelModalController.js b/services/web/frontend/js/ide/history/controllers/HistoryV2DeleteLabelModalController.js index c31061f608..251bc79fd5 100644 --- a/services/web/frontend/js/ide/history/controllers/HistoryV2DeleteLabelModalController.js +++ b/services/web/frontend/js/ide/history/controllers/HistoryV2DeleteLabelModalController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/controllers/HistoryV2FileTreeController.js b/services/web/frontend/js/ide/history/controllers/HistoryV2FileTreeController.js index 882030e17c..45f392d081 100644 --- a/services/web/frontend/js/ide/history/controllers/HistoryV2FileTreeController.js +++ b/services/web/frontend/js/ide/history/controllers/HistoryV2FileTreeController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/controllers/HistoryV2ListController.js b/services/web/frontend/js/ide/history/controllers/HistoryV2ListController.js index 2e1e72abd6..7e0832a7a2 100644 --- a/services/web/frontend/js/ide/history/controllers/HistoryV2ListController.js +++ b/services/web/frontend/js/ide/history/controllers/HistoryV2ListController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/controllers/HistoryV2ToolbarController.js b/services/web/frontend/js/ide/history/controllers/HistoryV2ToolbarController.js index 8f58499ac1..b3b04897d7 100644 --- a/services/web/frontend/js/ide/history/controllers/HistoryV2ToolbarController.js +++ b/services/web/frontend/js/ide/history/controllers/HistoryV2ToolbarController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, camelcase, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/history/directives/infiniteScroll.js b/services/web/frontend/js/ide/history/directives/infiniteScroll.js index 2785df3d3c..d653cc9882 100644 --- a/services/web/frontend/js/ide/history/directives/infiniteScroll.js +++ b/services/web/frontend/js/ide/history/directives/infiniteScroll.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/history/util/HistoryViewModes.js b/services/web/frontend/js/ide/history/util/HistoryViewModes.js index f2af60047a..2e200081e5 100644 --- a/services/web/frontend/js/ide/history/util/HistoryViewModes.js +++ b/services/web/frontend/js/ide/history/util/HistoryViewModes.js @@ -1,6 +1,5 @@ /* eslint-disable no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/history/util/displayNameForUser.js b/services/web/frontend/js/ide/history/util/displayNameForUser.js index b7dbfac048..0c86357b71 100644 --- a/services/web/frontend/js/ide/history/util/displayNameForUser.js +++ b/services/web/frontend/js/ide/history/util/displayNameForUser.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/hotkeys/BackspaceHighjack.js b/services/web/frontend/js/ide/hotkeys/BackspaceHighjack.js index 8d3476d2f8..54e2d47714 100644 --- a/services/web/frontend/js/ide/hotkeys/BackspaceHighjack.js +++ b/services/web/frontend/js/ide/hotkeys/BackspaceHighjack.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/hotkeys/controllers/HotkeysController.js b/services/web/frontend/js/ide/hotkeys/controllers/HotkeysController.js index 05e497c44b..625a607043 100644 --- a/services/web/frontend/js/ide/hotkeys/controllers/HotkeysController.js +++ b/services/web/frontend/js/ide/hotkeys/controllers/HotkeysController.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/hotkeys/index.js b/services/web/frontend/js/ide/hotkeys/index.js index 923e6e99b8..bd482ec221 100644 --- a/services/web/frontend/js/ide/hotkeys/index.js +++ b/services/web/frontend/js/ide/hotkeys/index.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogs.js b/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogs.js index ff1d84d1a1..e0d20f880f 100644 --- a/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogs.js +++ b/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogs.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogsRules.js b/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogsRules.js index ba4a23347b..16cad7353f 100644 --- a/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogsRules.js +++ b/services/web/frontend/js/ide/human-readable-logs/HumanReadableLogsRules.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, no-useless-escape, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/metadata/MetadataManager.js b/services/web/frontend/js/ide/metadata/MetadataManager.js index d2c59b3719..44d54d47ce 100644 --- a/services/web/frontend/js/ide/metadata/MetadataManager.js +++ b/services/web/frontend/js/ide/metadata/MetadataManager.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/metadata/services/metadata.js b/services/web/frontend/js/ide/metadata/services/metadata.js index 9249c51348..5c7c760863 100644 --- a/services/web/frontend/js/ide/metadata/services/metadata.js +++ b/services/web/frontend/js/ide/metadata/services/metadata.js @@ -1,6 +1,5 @@ /* eslint-disable no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/online-users/OnlineUsersManager.js b/services/web/frontend/js/ide/online-users/OnlineUsersManager.js index 8debd07a7c..1c1a322346 100644 --- a/services/web/frontend/js/ide/online-users/OnlineUsersManager.js +++ b/services/web/frontend/js/ide/online-users/OnlineUsersManager.js @@ -3,7 +3,6 @@ handle-callback-err, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/online-users/controllers/OnlineUsersController.js b/services/web/frontend/js/ide/online-users/controllers/OnlineUsersController.js index 6c75cd1c7f..e78a3eaefa 100644 --- a/services/web/frontend/js/ide/online-users/controllers/OnlineUsersController.js +++ b/services/web/frontend/js/ide/online-users/controllers/OnlineUsersController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/pdf/PdfManager.js b/services/web/frontend/js/ide/pdf/PdfManager.js index 4ea13ad009..37bf933c37 100644 --- a/services/web/frontend/js/ide/pdf/PdfManager.js +++ b/services/web/frontend/js/ide/pdf/PdfManager.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/pdf/controllers/PdfViewToggleController.js b/services/web/frontend/js/ide/pdf/controllers/PdfViewToggleController.js index d5bd552bba..c69d51684f 100644 --- a/services/web/frontend/js/ide/pdf/controllers/PdfViewToggleController.js +++ b/services/web/frontend/js/ide/pdf/controllers/PdfViewToggleController.js @@ -1,6 +1,5 @@ /* eslint-disable no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/pdfng/directives/pdfHighlights.js b/services/web/frontend/js/ide/pdfng/directives/pdfHighlights.js index a27038d4d5..bafb00302a 100644 --- a/services/web/frontend/js/ide/pdfng/directives/pdfHighlights.js +++ b/services/web/frontend/js/ide/pdfng/directives/pdfHighlights.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/pdfng/directives/pdfJs.js b/services/web/frontend/js/ide/pdfng/directives/pdfJs.js index ddaf77b1d7..8b37aaf902 100644 --- a/services/web/frontend/js/ide/pdfng/directives/pdfJs.js +++ b/services/web/frontend/js/ide/pdfng/directives/pdfJs.js @@ -2,7 +2,6 @@ max-len, no-cond-assign, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/pdfng/directives/pdfPage.js b/services/web/frontend/js/ide/pdfng/directives/pdfPage.js index b106793135..cfd2d28015 100644 --- a/services/web/frontend/js/ide/pdfng/directives/pdfPage.js +++ b/services/web/frontend/js/ide/pdfng/directives/pdfPage.js @@ -2,7 +2,6 @@ max-len, new-cap, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/pdfng/directives/pdfRenderer.js b/services/web/frontend/js/ide/pdfng/directives/pdfRenderer.js index 8330f0b9f2..db81a4a9fe 100644 --- a/services/web/frontend/js/ide/pdfng/directives/pdfRenderer.js +++ b/services/web/frontend/js/ide/pdfng/directives/pdfRenderer.js @@ -3,7 +3,6 @@ max-len, new-cap, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/pdfng/directives/pdfSpinner.js b/services/web/frontend/js/ide/pdfng/directives/pdfSpinner.js index 12eedbb478..d838f5c3d8 100644 --- a/services/web/frontend/js/ide/pdfng/directives/pdfSpinner.js +++ b/services/web/frontend/js/ide/pdfng/directives/pdfSpinner.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, no-unused-vars, no-useless-constructor, */ diff --git a/services/web/frontend/js/ide/pdfng/directives/pdfTextLayer.js b/services/web/frontend/js/ide/pdfng/directives/pdfTextLayer.js index c2d7705f53..b3bc22993b 100644 --- a/services/web/frontend/js/ide/pdfng/directives/pdfTextLayer.js +++ b/services/web/frontend/js/ide/pdfng/directives/pdfTextLayer.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/pdfng/directives/pdfViewer.js b/services/web/frontend/js/ide/pdfng/directives/pdfViewer.js index 07a2dc7e35..a106857d3b 100644 --- a/services/web/frontend/js/ide/pdfng/directives/pdfViewer.js +++ b/services/web/frontend/js/ide/pdfng/directives/pdfViewer.js @@ -4,7 +4,6 @@ new-cap, no-return-assign, no-sequences, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/permissions/PermissionsManager.js b/services/web/frontend/js/ide/permissions/PermissionsManager.js index 4853c7003d..251dddb8e8 100644 --- a/services/web/frontend/js/ide/permissions/PermissionsManager.js +++ b/services/web/frontend/js/ide/permissions/PermissionsManager.js @@ -1,6 +1,5 @@ /* eslint-disable no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/preamble/services/preamble.js b/services/web/frontend/js/ide/preamble/services/preamble.js index 3b2b0ee706..1d0bb1d702 100644 --- a/services/web/frontend/js/ide/preamble/services/preamble.js +++ b/services/web/frontend/js/ide/preamble/services/preamble.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/references/ReferencesManager.js b/services/web/frontend/js/ide/references/ReferencesManager.js index 13f3c01fa1..7c08c55ed0 100644 --- a/services/web/frontend/js/ide/references/ReferencesManager.js +++ b/services/web/frontend/js/ide/references/ReferencesManager.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/review-panel/RangesTracker.js b/services/web/frontend/js/ide/review-panel/RangesTracker.js index aadebf0ac7..190431bde8 100644 --- a/services/web/frontend/js/ide/review-panel/RangesTracker.js +++ b/services/web/frontend/js/ide/review-panel/RangesTracker.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/review-panel/ReviewPanelManager.js b/services/web/frontend/js/ide/review-panel/ReviewPanelManager.js index 02434f503d..f920d89dac 100644 --- a/services/web/frontend/js/ide/review-panel/ReviewPanelManager.js +++ b/services/web/frontend/js/ide/review-panel/ReviewPanelManager.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/controllers/BulkActionsModalController.js b/services/web/frontend/js/ide/review-panel/controllers/BulkActionsModalController.js index 8a4d7a96f8..42f2cfd960 100644 --- a/services/web/frontend/js/ide/review-panel/controllers/BulkActionsModalController.js +++ b/services/web/frontend/js/ide/review-panel/controllers/BulkActionsModalController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js b/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js index e6094521af..a0c5aa14e0 100644 --- a/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js +++ b/services/web/frontend/js/ide/review-panel/controllers/ReviewPanelController.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/review-panel/controllers/TrackChangesUpgradeModalController.js b/services/web/frontend/js/ide/review-panel/controllers/TrackChangesUpgradeModalController.js index c4efbc9247..39c4a00a2d 100644 --- a/services/web/frontend/js/ide/review-panel/controllers/TrackChangesUpgradeModalController.js +++ b/services/web/frontend/js/ide/review-panel/controllers/TrackChangesUpgradeModalController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/directives/aggregateChangeEntry.js b/services/web/frontend/js/ide/review-panel/directives/aggregateChangeEntry.js index cf8e595ccd..53f696891e 100644 --- a/services/web/frontend/js/ide/review-panel/directives/aggregateChangeEntry.js +++ b/services/web/frontend/js/ide/review-panel/directives/aggregateChangeEntry.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/directives/bulkActionsEntry.js b/services/web/frontend/js/ide/review-panel/directives/bulkActionsEntry.js index 9772fc3fe1..4655327f95 100644 --- a/services/web/frontend/js/ide/review-panel/directives/bulkActionsEntry.js +++ b/services/web/frontend/js/ide/review-panel/directives/bulkActionsEntry.js @@ -1,6 +1,5 @@ /* eslint-disable no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/directives/changeEntry.js b/services/web/frontend/js/ide/review-panel/directives/changeEntry.js index 722be7f359..90f0326b0b 100644 --- a/services/web/frontend/js/ide/review-panel/directives/changeEntry.js +++ b/services/web/frontend/js/ide/review-panel/directives/changeEntry.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/directives/commentEntry.js b/services/web/frontend/js/ide/review-panel/directives/commentEntry.js index fdc692fba8..19c50ec13e 100644 --- a/services/web/frontend/js/ide/review-panel/directives/commentEntry.js +++ b/services/web/frontend/js/ide/review-panel/directives/commentEntry.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/directives/resolvedCommentEntry.js b/services/web/frontend/js/ide/review-panel/directives/resolvedCommentEntry.js index 3f7e1ca16a..d9b553c468 100644 --- a/services/web/frontend/js/ide/review-panel/directives/resolvedCommentEntry.js +++ b/services/web/frontend/js/ide/review-panel/directives/resolvedCommentEntry.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/directives/resolvedCommentsDropdown.js b/services/web/frontend/js/ide/review-panel/directives/resolvedCommentsDropdown.js index 16b9e19a93..7723a1879c 100644 --- a/services/web/frontend/js/ide/review-panel/directives/resolvedCommentsDropdown.js +++ b/services/web/frontend/js/ide/review-panel/directives/resolvedCommentsDropdown.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/directives/reviewPanelCollapseHeight.js b/services/web/frontend/js/ide/review-panel/directives/reviewPanelCollapseHeight.js index 2308bac11e..18171f02a9 100644 --- a/services/web/frontend/js/ide/review-panel/directives/reviewPanelCollapseHeight.js +++ b/services/web/frontend/js/ide/review-panel/directives/reviewPanelCollapseHeight.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js b/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js index be4f7ff090..d1b93c6160 100644 --- a/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js +++ b/services/web/frontend/js/ide/review-panel/directives/reviewPanelSorted.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/review-panel/directives/reviewPanelToggle.js b/services/web/frontend/js/ide/review-panel/directives/reviewPanelToggle.js index 9b1711bfa0..f89bd2f95b 100644 --- a/services/web/frontend/js/ide/review-panel/directives/reviewPanelToggle.js +++ b/services/web/frontend/js/ide/review-panel/directives/reviewPanelToggle.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/filters/notEmpty.js b/services/web/frontend/js/ide/review-panel/filters/notEmpty.js index d8185461ec..6aaad02044 100644 --- a/services/web/frontend/js/ide/review-panel/filters/notEmpty.js +++ b/services/web/frontend/js/ide/review-panel/filters/notEmpty.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/filters/numKeys.js b/services/web/frontend/js/ide/review-panel/filters/numKeys.js index 1084178f86..d88e0bcdce 100644 --- a/services/web/frontend/js/ide/review-panel/filters/numKeys.js +++ b/services/web/frontend/js/ide/review-panel/filters/numKeys.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/review-panel/filters/orderOverviewEntries.js b/services/web/frontend/js/ide/review-panel/filters/orderOverviewEntries.js index c683ed65ea..88b9952e57 100644 --- a/services/web/frontend/js/ide/review-panel/filters/orderOverviewEntries.js +++ b/services/web/frontend/js/ide/review-panel/filters/orderOverviewEntries.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/services/ide.js b/services/web/frontend/js/ide/services/ide.js index c7964975e4..2fbdc8d469 100644 --- a/services/web/frontend/js/ide/services/ide.js +++ b/services/web/frontend/js/ide/services/ide.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/settings/controllers/ProjectNameController.js b/services/web/frontend/js/ide/settings/controllers/ProjectNameController.js index 3d284de5c8..d83f4b13ce 100644 --- a/services/web/frontend/js/ide/settings/controllers/ProjectNameController.js +++ b/services/web/frontend/js/ide/settings/controllers/ProjectNameController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/ide/settings/controllers/SettingsController.js b/services/web/frontend/js/ide/settings/controllers/SettingsController.js index 130701be80..e3edc22cd5 100644 --- a/services/web/frontend/js/ide/settings/controllers/SettingsController.js +++ b/services/web/frontend/js/ide/settings/controllers/SettingsController.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/settings/index.js b/services/web/frontend/js/ide/settings/index.js index 14114e1e44..7fe8bd2461 100644 --- a/services/web/frontend/js/ide/settings/index.js +++ b/services/web/frontend/js/ide/settings/index.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/settings/services/settings.js b/services/web/frontend/js/ide/settings/services/settings.js index b26d799e2c..b5d84ecd10 100644 --- a/services/web/frontend/js/ide/settings/services/settings.js +++ b/services/web/frontend/js/ide/settings/services/settings.js @@ -1,7 +1,6 @@ /* eslint-disable camelcase, max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/wordcount/controllers/WordCountController.js b/services/web/frontend/js/ide/wordcount/controllers/WordCountController.js index 2046be404d..8089bd78d6 100644 --- a/services/web/frontend/js/ide/wordcount/controllers/WordCountController.js +++ b/services/web/frontend/js/ide/wordcount/controllers/WordCountController.js @@ -1,6 +1,5 @@ /* eslint-disable no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/wordcount/controllers/WordCountModalController.js b/services/web/frontend/js/ide/wordcount/controllers/WordCountModalController.js index 8e0b18551e..726ec95838 100644 --- a/services/web/frontend/js/ide/wordcount/controllers/WordCountModalController.js +++ b/services/web/frontend/js/ide/wordcount/controllers/WordCountModalController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/ide/wordcount/index.js b/services/web/frontend/js/ide/wordcount/index.js index 9c47c2b918..841abdc3ca 100644 --- a/services/web/frontend/js/ide/wordcount/index.js +++ b/services/web/frontend/js/ide/wordcount/index.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main.js b/services/web/frontend/js/main.js index b915aca731..f10c258a91 100644 --- a/services/web/frontend/js/main.js +++ b/services/web/frontend/js/main.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/affiliations/components/affiliationForm.js b/services/web/frontend/js/main/affiliations/components/affiliationForm.js index 82d0d0f9b4..740a65bf4f 100644 --- a/services/web/frontend/js/main/affiliations/components/affiliationForm.js +++ b/services/web/frontend/js/main/affiliations/components/affiliationForm.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/affiliations/controllers/UserAffiliationsController.js b/services/web/frontend/js/main/affiliations/controllers/UserAffiliationsController.js index c40f695d27..1630801fcd 100644 --- a/services/web/frontend/js/main/affiliations/controllers/UserAffiliationsController.js +++ b/services/web/frontend/js/main/affiliations/controllers/UserAffiliationsController.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-useless-escape, */ diff --git a/services/web/frontend/js/main/annual-upgrade.js b/services/web/frontend/js/main/annual-upgrade.js index 69e247646e..3db78e141c 100644 --- a/services/web/frontend/js/main/annual-upgrade.js +++ b/services/web/frontend/js/main/annual-upgrade.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/bonus.js b/services/web/frontend/js/main/bonus.js index 5d0adf4429..31fc618848 100644 --- a/services/web/frontend/js/main/bonus.js +++ b/services/web/frontend/js/main/bonus.js @@ -1,6 +1,5 @@ /* eslint-disable no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/clear-sessions.js b/services/web/frontend/js/main/clear-sessions.js index d69a3bc827..ce2fb67bf6 100644 --- a/services/web/frontend/js/main/clear-sessions.js +++ b/services/web/frontend/js/main/clear-sessions.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/contact-us.js b/services/web/frontend/js/main/contact-us.js index b3d767fa78..cb92c1fe6a 100644 --- a/services/web/frontend/js/main/contact-us.js +++ b/services/web/frontend/js/main/contact-us.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. @@ -13,7 +12,12 @@ * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md */ define(['../base'], App => - App.controller('GroupPlanContactController', function($scope, $modal, $http) { + App.controller('GroupPlanContactController', function( + $scope, + $modal, + $http, + eventTracking + ) { $scope.form = {} $scope.sent = false $scope.sending = false diff --git a/services/web/frontend/js/main/event.js b/services/web/frontend/js/main/event.js index fa0b98fb21..2be040b6a4 100644 --- a/services/web/frontend/js/main/event.js +++ b/services/web/frontend/js/main/event.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. @@ -21,17 +20,6 @@ define(['moment', '../base', '../modules/localStorage'], function(moment, App) { let heartbeatsSent = 0 let nextHeartbeat = new Date() - const send = function(category, action, attributes) { - if (attributes == null) { - attributes = {} - } - ga('send', 'event', category, action) - const event_name = `${action}-${category}` - return typeof Intercom === 'function' - ? Intercom('trackEvent', event_name, attributes) - : undefined - } - App.factory('eventTracking', function($http, localStorage) { const _getEventCache = function() { let eventCache = localStorage(CACHE_KEY) diff --git a/services/web/frontend/js/main/keys.js b/services/web/frontend/js/main/keys.js index 7ee949183c..47c4311aa4 100644 --- a/services/web/frontend/js/main/keys.js +++ b/services/web/frontend/js/main/keys.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/learn.js b/services/web/frontend/js/main/learn.js index af838ac458..345400eb4f 100644 --- a/services/web/frontend/js/main/learn.js +++ b/services/web/frontend/js/main/learn.js @@ -3,7 +3,6 @@ handle-callback-err, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/project-list/index.js b/services/web/frontend/js/main/project-list/index.js index 49ee59db8f..06d1d164ca 100644 --- a/services/web/frontend/js/main/project-list/index.js +++ b/services/web/frontend/js/main/project-list/index.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/project-list/modal-controllers.js b/services/web/frontend/js/main/project-list/modal-controllers.js index 337c959070..89fd1bbfad 100644 --- a/services/web/frontend/js/main/project-list/modal-controllers.js +++ b/services/web/frontend/js/main/project-list/modal-controllers.js @@ -2,7 +2,6 @@ handle-callback-err, max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/register-users.js b/services/web/frontend/js/main/register-users.js index d268a7a650..4b0096abaa 100644 --- a/services/web/frontend/js/main/register-users.js +++ b/services/web/frontend/js/main/register-users.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/scribtex-popup.js b/services/web/frontend/js/main/scribtex-popup.js index 8d8b7aff75..ab924845cf 100644 --- a/services/web/frontend/js/main/scribtex-popup.js +++ b/services/web/frontend/js/main/scribtex-popup.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/subscription-dashboard.js b/services/web/frontend/js/main/subscription-dashboard.js index 3b1bed2891..7ff3808a02 100644 --- a/services/web/frontend/js/main/subscription-dashboard.js +++ b/services/web/frontend/js/main/subscription-dashboard.js @@ -1,8 +1,9 @@ +/* global recurly */ + /* eslint-disable camelcase, max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. @@ -168,7 +169,8 @@ define(['../base'], function(App) { App.controller('RecurlySubscriptionController', function($scope) { const recurlyIsSetup = ensureRecurlyIsSetup() - $scope.showChangePlanButton = recurlyIsSetup && !subscription.groupPlan + $scope.showChangePlanButton = + recurlyIsSetup && !window.subscription.groupPlan $scope.recurlyLoadError = !recurlyIsSetup $scope.switchToDefaultView = () => { diff --git a/services/web/frontend/js/main/subscription/team-invite-controller.js b/services/web/frontend/js/main/subscription/team-invite-controller.js index 27289c259c..8a9bdb0ede 100644 --- a/services/web/frontend/js/main/subscription/team-invite-controller.js +++ b/services/web/frontend/js/main/subscription/team-invite-controller.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. @@ -14,7 +13,7 @@ define(['../../base'], App => App.controller('TeamInviteController', function($scope, $http) { $scope.inflight = false - if (hasIndividualRecurlySubscription) { + if (window.hasIndividualRecurlySubscription) { $scope.view = 'hasIndividualRecurlySubscription' } else { $scope.view = 'teamInvite' diff --git a/services/web/frontend/js/main/system-messages.js b/services/web/frontend/js/main/system-messages.js index 2b80282042..65fd7138f3 100644 --- a/services/web/frontend/js/main/system-messages.js +++ b/services/web/frontend/js/main/system-messages.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/translations.js b/services/web/frontend/js/main/translations.js index 089a60225e..14a13a7cb2 100644 --- a/services/web/frontend/js/main/translations.js +++ b/services/web/frontend/js/main/translations.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/main/user-membership.js b/services/web/frontend/js/main/user-membership.js index 94518b0584..362dddccf2 100644 --- a/services/web/frontend/js/main/user-membership.js +++ b/services/web/frontend/js/main/user-membership.js @@ -1,7 +1,6 @@ /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. @@ -48,7 +47,7 @@ define(['../base'], function(App) { return Array.from(emails).map(email => { $scope.inputs.addMembers.inflightCount += 1 return queuedHttp - .post(paths.addMember, { + .post(window.paths.addMember, { email, _csrf: window.csrfToken }) @@ -76,10 +75,12 @@ define(['../base'], function(App) { for (let user of Array.from($scope.selectedUsers)) { ;(function(user) { let url - if (paths.removeInvite && user.invite && user._id == null) { - url = `${paths.removeInvite}/${encodeURIComponent(user.email)}` - } else if (paths.removeMember && user._id != null) { - url = `${paths.removeMember}/${user._id}` + if (window.paths.removeInvite && user.invite && user._id == null) { + url = `${window.paths.removeInvite}/${encodeURIComponent( + user.email + )}` + } else if (window.paths.removeMember && user._id != null) { + url = `${window.paths.removeMember}/${user._id}` } else { return } diff --git a/services/web/frontend/js/modules/errorCatcher.js b/services/web/frontend/js/modules/errorCatcher.js index 967cc8c31e..539c2a49e1 100644 --- a/services/web/frontend/js/modules/errorCatcher.js +++ b/services/web/frontend/js/modules/errorCatcher.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/modules/recursionHelper.js b/services/web/frontend/js/modules/recursionHelper.js index add14bf95e..f0c500d66a 100644 --- a/services/web/frontend/js/modules/recursionHelper.js +++ b/services/web/frontend/js/modules/recursionHelper.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/services/algolia-search.js b/services/web/frontend/js/services/algolia-search.js index 35c0d8fc4d..eb5f7eede7 100644 --- a/services/web/frontend/js/services/algolia-search.js +++ b/services/web/frontend/js/services/algolia-search.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/services/queued-http.js b/services/web/frontend/js/services/queued-http.js index 562e14629f..094a000415 100644 --- a/services/web/frontend/js/services/queued-http.js +++ b/services/web/frontend/js/services/queued-http.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, standard/no-callback-literal, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/services/validateCaptcha.js b/services/web/frontend/js/services/validateCaptcha.js index cc979f7612..75ba05c66b 100644 --- a/services/web/frontend/js/services/validateCaptcha.js +++ b/services/web/frontend/js/services/validateCaptcha.js @@ -1,6 +1,7 @@ +/* global grecaptcha */ + /* eslint-disable no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/services/wait-for.js b/services/web/frontend/js/services/wait-for.js index 34e3f12740..56bb8ccf8a 100644 --- a/services/web/frontend/js/services/wait-for.js +++ b/services/web/frontend/js/services/wait-for.js @@ -1,6 +1,5 @@ /* eslint-disable max-len, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint. diff --git a/services/web/frontend/js/utils/EventEmitter.js b/services/web/frontend/js/utils/EventEmitter.js index 559efa6aa4..710e91aa46 100644 --- a/services/web/frontend/js/utils/EventEmitter.js +++ b/services/web/frontend/js/utils/EventEmitter.js @@ -2,7 +2,6 @@ camelcase, max-len, no-return-assign, - no-undef, no-unused-vars, */ // TODO: This file was created by bulk-decaffeinate. diff --git a/services/web/frontend/js/utils/underscore.js b/services/web/frontend/js/utils/underscore.js index 7f3e679274..15b5e4e89c 100644 --- a/services/web/frontend/js/utils/underscore.js +++ b/services/web/frontend/js/utils/underscore.js @@ -1,5 +1,4 @@ /* eslint-disable - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint.