github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

default to USD in geo ip lookup.

Browse source 
Decided to put default logic in the GeoIpLookup.getCurrencyCode as
we are going to want this default everywhere we use it.
This commit is contained in:
Henry Oswald 2014-10-13 13:08:11 +01:00
parent e78e4d46b0
commit 2e6c2c1926
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/app/coffee/infrastructure/GeoIpLookup.coffee
View file

@ -30,5 +30,7 @@ module.exports = GeoIpLookup =
getCurrencyCode : (ip, callback)-> getCurrencyCode : (ip, callback)->
GeoIpLookup.getDetails ip, (err, ipDetails)-> GeoIpLookup.getDetails ip, (err, ipDetails)->
if err? or !ipDetails?
return callback(null, "USD")
currencyCode = currencyMappings[ipDetails?.country_code?.toUpperCase()] currencyCode = currencyMappings[ipDetails?.country_code?.toUpperCase()]
callback(err, currencyCode) callback(err, currencyCode)

12
services/web/test/UnitTests/coffee/infrastructure/GeoIpLookupTests.coffee
View file

@ -82,3 +82,15 @@ describe "GeoIpLookup", ->
@GeoIpLookup.getCurrencyCode @ipAddress, (err, currencyCode)-> @GeoIpLookup.getCurrencyCode @ipAddress, (err, currencyCode)->
currencyCode.should.equal "EUR" currencyCode.should.equal "EUR"
done() done()
it "should default to USD if there is an error", (done)->
@GeoIpLookup.getDetails = sinon.stub().callsArgWith(1, "problem")
@GeoIpLookup.getCurrencyCode @ipAddress, (err, currencyCode)->
currencyCode.should.equal "USD"
done()
it "should default to USD if there are no details", (done)->
@GeoIpLookup.getDetails = sinon.stub().callsArgWith(1)
@GeoIpLookup.getCurrencyCode @ipAddress, (err, currencyCode)->
currencyCode.should.equal "USD"
done()