From 2e0db2a472213854b67d316dd4b4303ede511d79 Mon Sep 17 00:00:00 2001 From: Alasdair Smith Date: Tue, 23 Jun 2020 09:57:18 +0100 Subject: [PATCH] Merge pull request #2940 from overleaf/as-cleanup-no-undef-disables Clean up disabling of no-undef eslint rule in frontend GitOrigin-RevId: 3fb19256b7dd9d41626355960dd9fbcc541e663f --- services/web/.eslintrc | 3 --- .../frontend/js/main/controllers/LaunchpadController.js | 3 ++- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/services/web/.eslintrc b/services/web/.eslintrc index 0c74136c81..592de70fed 100644 --- a/services/web/.eslintrc +++ b/services/web/.eslintrc @@ -81,7 +81,6 @@ "files": ["**/test/frontend/**/*.js"], "globals": { "expect": true, - "define": true, "$": true } }, @@ -97,10 +96,8 @@ // Frontend specific rules "files": ["**/frontend/js/**/*.js"], "globals": { - "define": true, "$": true, "angular": true, - "_": true, "ace": true, "ga": true, "Raven": true, // Backwards compat for Sentry reporting diff --git a/services/web/modules/launchpad/frontend/js/main/controllers/LaunchpadController.js b/services/web/modules/launchpad/frontend/js/main/controllers/LaunchpadController.js index e8e6542a63..446e9145e6 100644 --- a/services/web/modules/launchpad/frontend/js/main/controllers/LaunchpadController.js +++ b/services/web/modules/launchpad/frontend/js/main/controllers/LaunchpadController.js @@ -1,7 +1,8 @@ +/* global io */ + /* eslint-disable max-len, no-return-assign, - no-undef, */ // TODO: This file was created by bulk-decaffeinate. // Fix any style issues and re-enable lint.