github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-06 15:12:07 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use 422 status when rejecting Git LFS request

Browse source
This commit is contained in:
Shane Kilkelly 2020-08-05 13:00:20 +01:00
parent f7125b9159
commit 2b8f3f4de8
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/git-bridge/src/main/java/uk/ac/ic/wlgitbridge/server/GitLfsHandler.java
View file

@ -37,7 +37,7 @@ public class GitLfsHandler extends AbstractHandler {
) {
Log.info(method + " <- /<project>.git/info/lfs/objects/batch");
response.setContentType("application/vnd.git-lfs+json");
response.setStatus(406);
response.setStatus(422);
response.getWriter().println("{\"message\": \"ERROR: Git LFS is not supported on Overleaf\"}");
baseRequest.setHandled(true);
}

2
services/git-bridge/src/test/java/uk/ac/ic/wlgitbridge/application/WLGitBridgeIntegrationTest.java
View file

@ -989,7 +989,7 @@ public class WLGitBridgeIntegrationTest {
String urlBase = "http://127.0.0.1:" + gitBridgePort;
HttpPost gitLfsRequest = new HttpPost(urlBase+"/5f2419407929eb0026641967.git/info/lfs/objects/batch");
HttpResponse gitLfsResponse = client.execute(gitLfsRequest);
assertEquals(406, gitLfsResponse.getStatusLine().getStatusCode());
assertEquals(422, gitLfsResponse.getStatusLine().getStatusCode());
HttpEntity entity = gitLfsResponse.getEntity();
String responseString = EntityUtils.toString(entity, "UTF-8");
assertTrue(responseString.contains("Git LFS is not supported on Overleaf"));