From 2aaadc61248b808d1aad19df4122edae88e0bc70 Mon Sep 17 00:00:00 2001
From: Henry Oswald <henry.oswald@sharelatex.com>
Date: Thu, 23 Aug 2018 00:12:05 +0100
Subject: [PATCH] fix unit tests

---
 services/clsi/app/coffee/LockManager.coffee   | 23 ++++++++++---------
 .../test/unit/coffee/LockManagerTests.coffee  |  3 ++-
 2 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/services/clsi/app/coffee/LockManager.coffee b/services/clsi/app/coffee/LockManager.coffee
index 2a8777fd30..afa3cca971 100644
--- a/services/clsi/app/coffee/LockManager.coffee
+++ b/services/clsi/app/coffee/LockManager.coffee
@@ -15,16 +15,17 @@ module.exports = LockManager =
 			pollPeriod: @LOCK_TEST_INTERVAL
 			stale: @LOCK_STALE
 		Lockfile.lock path, lockOpts, (error) ->
-			return callback new Errors.AlreadyCompilingError("compile in progress")	if error?.code is 'EEXIST'
-				if error?
-					fs.lstat path, (statLockErr, statLock)->
-						fs.lstat Path.dirname(path), (statDirErr, statDir)->
-							fs.readdir Path.dirname(path), (readdirErr, readdirDir)->
+			if error?.code is 'EEXIST'
+				return callback new Errors.AlreadyCompilingError("compile in progress")
+			else if error?
+				fs.lstat path, (statLockErr, statLock)->
+					fs.lstat Path.dirname(path), (statDirErr, statDir)->
+						fs.readdir Path.dirname(path), (readdirErr, readdirDir)->
 							logger.err error:error, path:path, statLock:statLock, statLockErr:statLockErr, statDir:statDir, statDirErr: statDirErr, readdirErr:readdirErr, readdirDir:readdirDir, "unable to get lock"
 							return callback(error)
-				else
-					runner (error1, args...) ->
-						Lockfile.unlock path, (error2) ->
-							error = error1 or error2
-							return callback(error) if error?
-							callback(null, args...)
+			else
+				runner (error1, args...) ->
+					Lockfile.unlock path, (error2) ->
+						error = error1 or error2
+						return callback(error) if error?
+						callback(null, args...)
diff --git a/services/clsi/test/unit/coffee/LockManagerTests.coffee b/services/clsi/test/unit/coffee/LockManagerTests.coffee
index ab9ce9385c..9dd1d46cbb 100644
--- a/services/clsi/test/unit/coffee/LockManagerTests.coffee
+++ b/services/clsi/test/unit/coffee/LockManagerTests.coffee
@@ -9,9 +9,10 @@ describe "DockerLockManager", ->
 	beforeEach ->
 		@LockManager = SandboxedModule.require modulePath, requires:
 			"settings-sharelatex": {}
-			"logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub() }
+			"logger-sharelatex": @logger = { log: sinon.stub(), error: sinon.stub(), err:-> }
 			"fs":
 				lstat:sinon.stub().callsArgWith(1)
+				readdir: sinon.stub().callsArgWith(1)
 			"lockfile": @Lockfile = {}
 		@lockFile = "/local/compile/directory/.project-lock"