diff --git a/services/contacts/.nvmrc b/services/contacts/.nvmrc index 5b7269c0a9..b61c07ffdd 100644 --- a/services/contacts/.nvmrc +++ b/services/contacts/.nvmrc @@ -1 +1 @@ -10.19.0 +10.21.0 diff --git a/services/contacts/Dockerfile b/services/contacts/Dockerfile index c014691791..7b47fb9ee2 100644 --- a/services/contacts/Dockerfile +++ b/services/contacts/Dockerfile @@ -2,7 +2,7 @@ # Instead run bin/update_build_scripts from # https://github.com/sharelatex/sharelatex-dev-environment -FROM node:10.19.0 as base +FROM node:10.21.0 as base WORKDIR /app diff --git a/services/contacts/Makefile b/services/contacts/Makefile index 7e0b5418ea..528bf7b0bd 100644 --- a/services/contacts/Makefile +++ b/services/contacts/Makefile @@ -17,13 +17,13 @@ clean: docker rmi gcr.io/overleaf-ops/$(PROJECT_NAME):$(BRANCH_NAME)-$(BUILD_NUMBER) format: - $(DOCKER_COMPOSE) run --rm test_unit npm run format + $(DOCKER_COMPOSE) run --rm test_unit npm run format || true format_fix: $(DOCKER_COMPOSE) run --rm test_unit npm run format:fix lint: - $(DOCKER_COMPOSE) run --rm test_unit npm run lint + $(DOCKER_COMPOSE) run --rm test_unit npm run lint || true test: format lint test_unit test_acceptance diff --git a/services/contacts/buildscript.txt b/services/contacts/buildscript.txt index 45f8590a8a..6548a2755a 100644 --- a/services/contacts/buildscript.txt +++ b/services/contacts/buildscript.txt @@ -5,6 +5,6 @@ contacts --env-add= --env-pass-through= --language=es ---node-version=10.19.0 +--node-version=10.21.0 --public-repo=False --script-version=2.0.0 diff --git a/services/contacts/docker-compose.yml b/services/contacts/docker-compose.yml index 09dbaf76ba..528fb5e77f 100644 --- a/services/contacts/docker-compose.yml +++ b/services/contacts/docker-compose.yml @@ -6,7 +6,7 @@ version: "2.3" services: test_unit: - image: node:10.19.0 + image: node:10.21.0 volumes: - .:/app working_dir: /app @@ -17,7 +17,7 @@ services: user: node test_acceptance: - image: node:10.19.0 + image: node:10.21.0 volumes: - .:/app working_dir: /app