github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity

decaf cleanup: remove unnecessary use of Array.from

Browse source 
GitOrigin-RevId: 78c835929c9d7c38e0231f8fbb3e16a35efb7498
This commit is contained in:
Tim Alby 2022-01-07 11:33:05 +01:00 committed by Copybot
parent efc131175c
commit 291f28a655
2 changed files with 4 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
services/chat/app/js/Features/Messages/MessageFormatter.js
View file

@ -1,10 +1,3 @@
// TODO: This file was created by bulk-decaffeinate.
// Fix any style issues and re-enable lint.
/*
* decaffeinate suggestions:
* DS101: Remove unnecessary use of Array.from
* Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
*/
let MessageFormatter let MessageFormatter
module.exports = MessageFormatter = { module.exports = MessageFormatter = {
formatMessageForClientSide(message) { formatMessageForClientSide(message) {
@ -25,15 +18,13 @@ module.exports = MessageFormatter = {
}, },
formatMessagesForClientSide(messages) { formatMessagesForClientSide(messages) {
return Array.from(messages).map(message => return messages.map(message => this.formatMessageForClientSide(message))
this.formatMessageForClientSide(message)
)
}, },
groupMessagesByThreads(rooms, messages) { groupMessagesByThreads(rooms, messages) {
let room, thread let room, thread
const roomsById = {} const roomsById = {}
for (room of Array.from(rooms)) { for (room of rooms) {
roomsById[room._id.toString()] = room roomsById[room._id.toString()] = room
} }
@ -54,7 +45,7 @@ module.exports = MessageFormatter = {
} }
} }
for (const message of Array.from(messages)) { for (const message of messages) {
room = roomsById[message.room_id.toString()] room = roomsById[message.room_id.toString()]
if (room) { if (room) {
thread = getThread(room) thread = getThread(room)

9
services/chat/test/acceptance/js/helpers/ChatApp.js
View file

@ -1,10 +1,3 @@
// TODO: This file was created by bulk-decaffeinate.
// Fix any style issues and re-enable lint.
/*
* decaffeinate suggestions:
* DS101: Remove unnecessary use of Array.from
* Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
*/
const { waitForDb } = require('../../../../app/js/mongodb') const { waitForDb } = require('../../../../app/js/mongodb')
const app = require('../../../../app') const app = require('../../../../app')
@ -29,7 +22,7 @@ module.exports = {
throw error throw error
} }
this.running = true this.running = true
for (callback of Array.from(this.callbacks)) { for (callback of this.callbacks) {
callback() callback()
} }
}) })