github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

add smoothing of delete spikes

Browse source
This commit is contained in:
Brian Gough 2019-10-01 15:01:53 +01:00
parent 2c22a60052
commit 2845b23b70
3 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/document-updater/app/coffee/RedisManager.coffee
View file

@ -295,8 +295,9 @@ module.exports = RedisManager =
multi.exec callback multi.exec callback
queueFlushAndDeleteProject: (project_id, callback) -> queueFlushAndDeleteProject: (project_id, callback) ->
# store the project id in a sorted set ordered by time # store the project id in a sorted set ordered by time with a random offset to smooth out spikes
rclient.zadd keys.flushAndDeleteQueue(), Date.now(), project_id, callback SMOOTHING_OFFSET = if Settings.smoothingOffset > 0 then Math.round(Settings.smoothingOffset * Math.random()) else 0
rclient.zadd keys.flushAndDeleteQueue(), Date.now() + SMOOTHING_OFFSET, project_id, callback
getNextProjectToFlushAndDelete: (cutoffTime, callback = (error, key, timestamp)->) -> getNextProjectToFlushAndDelete: (cutoffTime, callback = (error, key, timestamp)->) ->
# find the oldest queued flush that is before the cutoff time # find the oldest queued flush that is before the cutoff time

2
services/document-updater/config/settings.defaults.coffee
View file

@ -97,3 +97,5 @@ module.exports =
publishOnIndividualChannels: process.env['PUBLISH_ON_INDIVIDUAL_CHANNELS'] or false publishOnIndividualChannels: process.env['PUBLISH_ON_INDIVIDUAL_CHANNELS'] or false
continuousBackgroundFlush: process.env['CONTINUOUS_BACKGROUND_FLUSH'] or false continuousBackgroundFlush: process.env['CONTINUOUS_BACKGROUND_FLUSH'] or false
smoothingOffset: process.env['SMOOTHING_OFFSET'] or 1000 # milliseconds

5
services/document-updater/test/acceptance/coffee/DeletingAProjectTests.coffee
View file

@ -147,9 +147,8 @@ describe "Deleting a project", ->
@statusCode = res.statusCode @statusCode = res.statusCode
# after deleting the project and putting it in the queue, flush the queue # after deleting the project and putting it in the queue, flush the queue
setTimeout () -> setTimeout () ->
DocUpdaterClient.flushOldProjects (error, res, body) => DocUpdaterClient.flushOldProjects done
setTimeout done, 1000 # allow time for the flush to complete , 2000
, 100
, 200 , 200
after -> after ->