github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-09-16 02:52:31 -04:00
Code Issues Projects Releases Packages Wiki Activity

Rename TrackChangesToggleButton prop to match onMouseDown attribute (#12862)

Browse source 
GitOrigin-RevId: bf2a83c58298ee809f181d95beddec695d223922
This commit is contained in:
Alf Eaton 2023-05-03 09:27:13 +01:00 committed by Copybot
parent 09c5bf72d2
commit 2796f750ee
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
services/web/frontend/js/features/editor-navigation-toolbar/components/toolbar-header.js
View file

@ -68,7 +68,7 @@ const ToolbarHeader = React.memo(function ToolbarHeader({
{shouldDisplayTrackChangesButton && ( {shouldDisplayTrackChangesButton && (
<TrackChangesToggleButton <TrackChangesToggleButton
onClick={toggleReviewPanelOpen} onMouseDown={toggleReviewPanelOpen}
disabled={historyIsOpen} disabled={historyIsOpen}
trackChangesIsOpen={reviewPanelOpen} trackChangesIsOpen={reviewPanelOpen}
/> />

10
services/web/frontend/js/features/editor-navigation-toolbar/components/track-changes-toggle-button.js
View file

@ -2,7 +2,11 @@ import PropTypes from 'prop-types'
import classNames from 'classnames' import classNames from 'classnames'
import { useTranslation } from 'react-i18next' import { useTranslation } from 'react-i18next'
function TrackChangesToggleButton({ trackChangesIsOpen, disabled, onClick }) { function TrackChangesToggleButton({
trackChangesIsOpen,
disabled,
onMouseDown,
}) {
const { t } = useTranslation() const { t } = useTranslation()
const classes = classNames('btn', 'btn-full-height', { const classes = classNames('btn', 'btn-full-height', {
active: trackChangesIsOpen && !disabled, active: trackChangesIsOpen && !disabled,
@ -11,7 +15,7 @@ function TrackChangesToggleButton({ trackChangesIsOpen, disabled, onClick }) {
return ( return (
<div className="toolbar-item"> <div className="toolbar-item">
<button disabled={disabled} className={classes} onMouseDown={onClick}> <button disabled={disabled} className={classes} onMouseDown={onMouseDown}>
<i className="review-icon" /> <i className="review-icon" />
<p className="toolbar-label">{t('review')}</p> <p className="toolbar-label">{t('review')}</p>
</button> </button>
@ -22,7 +26,7 @@ function TrackChangesToggleButton({ trackChangesIsOpen, disabled, onClick }) {
TrackChangesToggleButton.propTypes = { TrackChangesToggleButton.propTypes = {
trackChangesIsOpen: PropTypes.bool, trackChangesIsOpen: PropTypes.bool,
disabled: PropTypes.bool, disabled: PropTypes.bool,
onClick: PropTypes.func.isRequired, onMouseDown: PropTypes.func.isRequired,
} }
export default TrackChangesToggleButton export default TrackChangesToggleButton