github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2025-04-14 03:26:50 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request from overleaf/sk-catch-gitbridge-content-errors

Browse source 
GitBridge: catch 404 errors when fetching content from git-bridge api
GitOrigin-RevId: 411759ebae1fb81ebfa942e117d1ef3c47215d0e
This commit is contained in:
Shane Kilkelly 2019-07-08 09:56:08 +01:00 • committed by sharelatex
parent 62a0c57021
commit 26af3e091f
1 changed files with 9 additions and 2 deletions

11
services/web/app/src/infrastructure/FileWriter.js
View file

@ -105,12 +105,19 @@ module.exports = FileWriter = {
}
callback = _.once(callback)
const stream = request.get(url)
return stream.on('response', function(response) {
stream.on('error', function(err) {
logger.warn(
{ err, identifier, url },
'[writeUrlToDisk] something went wrong with writing to disk'
)
callback(err)
})
stream.on('response', function(response) {
if (response.statusCode >= 200 && response.statusCode < 300) {
return FileWriter.writeStreamToDisk(identifier, stream, callback)
} else {
const err = new Error(`bad response from url: ${response.statusCode}`)
logger.warn({ err, identifier, url }, err.message)
logger.warn({ err, identifier, url }, `[writeUrlToDisk] ${err.message}`)
return callback(err)
}
})