From 25f75bbc41d6ca9a8a12e2e2d85245c70e00fd09 Mon Sep 17 00:00:00 2001 From: Eric Mc Sween Date: Thu, 9 Feb 2023 07:31:04 -0500 Subject: [PATCH] Merge pull request #11661 from overleaf/jpa-cleanup-clsi [clsi] delete unused DbQueue module and related config option GitOrigin-RevId: d9f1f84f82149efe1d7cdd75b2b45ba78e4defd2 --- services/clsi/README.md | 1 - services/clsi/app/js/DbQueue.js | 18 ------------------ services/clsi/config/settings.defaults.js | 1 - 3 files changed, 20 deletions(-) delete mode 100644 services/clsi/app/js/DbQueue.js diff --git a/services/clsi/README.md b/services/clsi/README.md index 0783d9ef30..11e35eb95d 100644 --- a/services/clsi/README.md +++ b/services/clsi/README.md @@ -25,7 +25,6 @@ The CLSI can be configured through the following environment variables: * `DOCKER_RUNTIME` - * `FILESTORE_DOMAIN_OVERRIDE` - The url for the filestore service e.g.`http://$FILESTORE_HOST:3009` * `FILESTORE_PARALLEL_FILE_DOWNLOADS` - Number of parallel file downloads -* `FILESTORE_PARALLEL_SQL_QUERY_LIMIT` - Number of parallel SQL queries * `LISTEN_ADDRESS` - The address for the RESTful service to listen on. Set to `0.0.0.0` to listen on all network interfaces * `PROCESS_LIFE_SPAN_LIMIT_MS` - Process life span limit in milliseconds * `SENTRY_DSN` - Sentry [Data Source Name](https://docs.sentry.io/product/sentry-basics/dsn-explainer/) diff --git a/services/clsi/app/js/DbQueue.js b/services/clsi/app/js/DbQueue.js deleted file mode 100644 index 2e011d5b02..0000000000 --- a/services/clsi/app/js/DbQueue.js +++ /dev/null @@ -1,18 +0,0 @@ -// TODO: This file was created by bulk-decaffeinate. -// Sanity-check the conversion and remove this comment. -/* - * decaffeinate suggestions: - * DS102: Remove unnecessary code created because of implicit returns - * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md - */ -const async = require('async') -const Settings = require('@overleaf/settings') -const logger = require('@overleaf/logger') -const queue = async.queue( - (task, cb) => task(cb), - Settings.parallelSqlQueryLimit -) - -queue.drain(() => logger.debug('all items have been processed')) - -module.exports = { queue } diff --git a/services/clsi/config/settings.defaults.js b/services/clsi/config/settings.defaults.js index 9a7d83539b..ae4cc51b67 100644 --- a/services/clsi/config/settings.defaults.js +++ b/services/clsi/config/settings.defaults.js @@ -49,7 +49,6 @@ module.exports = { smokeTest: process.env.SMOKE_TEST || false, project_cache_length_ms: 1000 * 60 * 60 * 24, parallelFileDownloads: process.env.FILESTORE_PARALLEL_FILE_DOWNLOADS || 1, - parallelSqlQueryLimit: process.env.FILESTORE_PARALLEL_SQL_QUERY_LIMIT || 1, filestoreDomainOveride: process.env.FILESTORE_DOMAIN_OVERRIDE, texliveImageNameOveride: process.env.TEX_LIVE_IMAGE_NAME_OVERRIDE, texliveOpenoutAny: process.env.TEXLIVE_OPENOUT_ANY,